GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-69093: Add mapping protocol support to sqlite3.Blob by erlend-aasland · Pull Request #91599 · python/cpython

Conversation

erlend-aasland commented Apr 16, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Originally written by @palaviv in gh-271.

Authored-by: Aviv Palivoda [email protected]
Co-authored-by: Erlend E. Aasland [email protected]

gh-69093

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

erlend-aasland requested a review from berkerpeksag as a code owner

April 16, 2022 07:11

bedevere-bot added the awaiting review label

Apr 16, 2022

erlend-aasland commented Apr 16, 2022

Copy link

Copy Markdown

Contributor Author

Let's land GH-91561 first.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland requested a review from JelleZijlstra

April 16, 2022 07:12


          pythongh-69093: Add mapping protocol support to sqlite3.Blob

38b2cdb

Authored-by: Aviv Palivoda <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>

erlend-aasland force-pushed the sqlite-blob-add-mapping-protocol branch from a84e0fb to 38b2cdb Compare

April 16, 2022 07:15

JelleZijlstra commented Apr 16, 2022

Copy link

Copy Markdown

Member

Let's land GH-91561 first.

Done, could you fix the conflict? I'll also review the code for this one now.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra reviewed

Apr 16, 2022

View reviewed changes

Comment thread

Modules/_sqlite/blob.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_sqlite/blob.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_sqlite/blob.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland marked this pull request as draft

April 16, 2022 17:56

Erlend E. Aasland added 4 commits

April 16, 2022 19:59


          Merge branch 'main' into sqlite-blob-add-mapping-protocol

8bc5762


          Cast

86e324a


          Assert lenght and offset

37a5c38


          Accept all buffer objects

a179749

erlend-aasland marked this pull request as ready for review

April 17, 2022 07:53

erlend-aasland requested a review from JelleZijlstra

April 17, 2022 09:00

JelleZijlstra reviewed

Apr 17, 2022

View reviewed changes

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland added 2 commits

April 18, 2022 23:57


          Address review: reword docs and modify example

ed6a9b6


          bugfix: use correct offset in inner read/write

233f940

erlend-aasland commented

Apr 18, 2022

View reviewed changes

Comment thread

Lib/test/test_sqlite3/test_dbapi.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra self-requested a review

April 18, 2022 22:25

JelleZijlstra reviewed

Apr 19, 2022

View reviewed changes

Comment thread

Lib/test/test_sqlite3/test_dbapi.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_sqlite3/test_dbapi.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Misc/NEWS.d/next/Library/2022-04-14-01-00-31.gh-issue-69093.bmlMwI.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Modules/_sqlite/blob.c Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Misc/NEWS.d/next/Library/2022-04-14-01-00-31.gh-issue-69093.bm…

9cbc339

…lMwI.rst

Co-authored-by: Jelle Zijlstra <[email protected]>

vstinner reviewed

Apr 19, 2022

View reviewed changes

Comment thread

Lib/test/test_sqlite3/test_dbapi.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend E. Aasland added 2 commits

April 19, 2022 22:25


          Address review: verify writes

7df4b9d


          Address review: Py_ssize_t iso. int

cb2619e

erlend-aasland requested a review from JelleZijlstra

April 21, 2022 07:47

JelleZijlstra approved these changes

Apr 22, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Apr 22, 2022

JelleZijlstra self-assigned this

Apr 22, 2022

JelleZijlstra merged commit 29afb7d into python:main

Apr 22, 2022

bedevere-bot removed the awaiting merge label

Apr 22, 2022

erlend-aasland deleted the sqlite-blob-add-mapping-protocol branch

April 22, 2022 07:44

erlend-aasland commented Apr 22, 2022

Copy link

Copy Markdown

Contributor Author

Thanks a lot, Jelle!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra mentioned this pull request

Apr 26, 2022

sqlite3: Add sequence methods to Blob python/typeshed#7684

Merged

serhiy-storchaka mentioned this pull request

May 30, 2026

sqlite3: Blob crashes when using a negative-step slice #150449

Closed

Reviewers

vstinner

vstinner left review comments

JelleZijlstra

JelleZijlstra approved these changes

berkerpeksag

Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Apr 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Apr 16, 2022

Uh oh!

JelleZijlstra commented Apr 16, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Apr 22, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

erlend-aasland commented Apr 16, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.