GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-69093: Add context manager support to sqlite3.Blob by erlend-aasland · Pull Request #91562 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 15, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Written by @palaviv in GH-271.

gh-69093

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Erlend E. Aasland
pythongh-69093: Add context manager support to sqlite3.Blob
b6cd651
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner April 15, 2022 07:02
@bedevere-bot bedevere-bot added the awaiting review label Apr 15, 2022
@erlend-aasland
erlend-aasland requested a review from JelleZijlstra April 15, 2022 07:02
JelleZijlstra
JelleZijlstra reviewed Apr 15, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, a query about the docs

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Erlend E. Aasland added 2 commits April 15, 2022 17:25
Erlend E. Aasland
Try to consolidate examples and reword docs
ca093f3
Erlend E. Aasland
Simplify and relocate example
bce9c9f
JelleZijlstra
JelleZijlstra approved these changes Apr 15, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Apr 15, 2022
@JelleZijlstra JelleZijlstra self-assigned this Apr 15, 2022
@JelleZijlstra
JelleZijlstra merged commit a861756 into python:main Apr 16, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Apr 16, 2022
JelleZijlstra added a commit to JelleZijlstra/typeshed that referenced this pull request Apr 16, 2022
@JelleZijlstra
blob.__enter__ from python/cpython#91562
6024e3f
@erlend-aasland
erlend-aasland deleted the sqlite-blob-add-ctx-mgr branch April 16, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.