GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-91217: deprecate nis by brettcannon · Pull Request #91606 · python/cpython

gh-91217: deprecate nis #91606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

miss-islington merged 1 commit into python:main from brettcannon:deprecate-nis

Apr 16, 2022

Uh oh!

There was an error while loading. Please reload this page.

Merged

gh-91217: deprecate nis #91606

Show file tree

Hide file tree

Changes from all commits

Commits

Select commit

brettcannon Apr 16, 2022

File filter

Filter by extension .c (1) .py (1) .rst (2) All 3 file types selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

1 change: 1 addition & 0 deletions 1 Doc/whatsnew/3.11.rst

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -875,6 +875,7 @@ Deprecated
		* :mod:`crypt`
		* :mod:`imghdr`
		* :mod:`msilib`
		* :mod:`nis`
		* :mod:`nntplib`

		(Contributed by Brett Cannon in :issue:`47061`.)
Expand Down

5 changes: 4 additions & 1 deletion 5 Lib/test/test_nis.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -1,10 +1,13 @@
		from test import support
		from test.support import import_helper
		import unittest
		import warnings


		# Skip test if nis module does not exist.
		nis = import_helper.import_module('nis')
		with warnings.catch_warnings():
		warnings.simplefilter("ignore", DeprecationWarning)
		nis = import_helper.import_module('nis')


		class NisTests(unittest.TestCase):
Expand Down

1 change: 1 addition & 0 deletions 1 Misc/NEWS.d/next/Library/2022-04-16-09-33-14.gh-issue-91217.nt9JFs.rst

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		Deprecate the nis module.

6 changes: 6 additions & 0 deletions 6 Modules/nismodule.c

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -524,5 +524,11 @@ static struct PyModuleDef nismodule = {
		PyMODINIT_FUNC
		PyInit_nis(void)
		{
		if (PyErr_WarnEx(PyExc_DeprecationWarning,
		"'nis' is deprecated and slated for removal in "
		"Python 3.13",
		7)) {
		return NULL;
		}
		return PyModuleDef_Init(&nismodule);
		}

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.