GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — gh-91928: Add `datetime.UTC` alias for `datetime.timezone.utc` by Kab1r · Pull Request #91973 · python/cpython Conversation
|
|
Every change to Python requires a NEWS entry. Please, add it using the blurb_it Web app or the blurb command-line tool. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks!
In addition to my other comments, two other things:
TestModule, like this:def test_utc_alias(self): self.assertIs(UTC, timezone.utc)
Thanks for your contribution!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I have made the requested changes; please review again |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for making the requested changes! @pganssle: please review the changes made to this pull request. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Can you add this test?
Maybe add a very simple test to TestModule, like this:
def test_utc_alias(self): self.assertIs(UTC, timezone.utc)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I had to move the definition of |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I have made the requested changes; please review again |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks for making the requested changes! @pganssle: please review the changes made to this pull request. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
1. Add UTC definition into C implementation as well (just for consistency, there's no particular reason not to simply assign the alias in the Python code later). 2. Move `..versionadded` tag into the right place
c097669 to
9542f54
Compare
|
Thanks @Kab1r! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Resolves an issue Ken reported running tests in the QA farm, which is due to use of an interface from more-recent-python: python/cpython#91973
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Adddatetime.UTC alias for datetime.timezone.utc
There was an error while loading. Please reload this page.