GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.10] gh-91810: Expand ElementTree.write() tests to use non-ASCII data (GH-91989) by miss-islington · Pull Request #91991 · python/cpython

Conversation

miss-islington commented Apr 27, 2022

Copy link

Copy Markdown

Contributor

(cherry picked from commit f60b4c3)

Co-authored-by: Serhiy Storchaka [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-91810: Expand ElementTree.write() tests to use non-ASCII data (

74fec20

pythonGH-91989)

(cherry picked from commit f60b4c3)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot added the skip news label

Apr 27, 2022

bedevere-bot mentioned this pull request

Apr 27, 2022

gh-91810: Expand ElementTree.write() tests to use non-ASCII data #91989

Merged

bedevere-bot added tests

Tests in the Lib/test dir

awaiting review labels

Apr 27, 2022

miss-islington commented Apr 27, 2022

Copy link

Copy Markdown

Contributor Author

@serhiy-storchaka: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment

miss-islington commented Apr 27, 2022

Copy link

Copy Markdown

Contributor Author

@serhiy-storchaka: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka approved these changes

Apr 27, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Apr 27, 2022

miss-islington commented Apr 27, 2022

Copy link

Copy Markdown

Contributor Author

Sorry, I can't merge this PR. Reason: 3 of 6 required status checks are expected..

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka approved these changes

Apr 27, 2022

View reviewed changes

miss-islington commented Apr 27, 2022

Copy link

Copy Markdown

Contributor Author

@serhiy-storchaka: Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington merged commit 777d478 into python:3.10

Apr 27, 2022

bedevere-bot removed the awaiting merge label

Apr 27, 2022

miss-islington deleted the backport-f60b4c3-3.10 branch

April 27, 2022 16:50

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.