GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91810: Expand ElementTree.write() tests to use non-ASCII data by serhiy-storchaka · Pull Request #91989 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Apr 27, 2022

Copy link
Copy Markdown
Member

#91810

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-91810: Expand ElementTree.write() tests to use non-ASCII data
68008bd
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.9 labels Apr 27, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Apr 27, 2022
@serhiy-storchaka
serhiy-storchaka merged commit f60b4c3 into python:main Apr 27, 2022
@miss-islington

miss-islington commented Apr 27, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Apr 27, 2022
@serhiy-storchaka
serhiy-storchaka deleted the test_xml_etree branch April 27, 2022 16:16
@miss-islington

miss-islington commented Apr 27, 2022

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f60b4c3d74f241775f80affe60dcba6448634fe3 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Apr 27, 2022
@bedevere-bot

bedevere-bot commented Apr 27, 2022

Copy link
Copy Markdown

GH-91991 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Apr 27, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 27, 2022
@serhiy-storchaka @miss-islington
pythongh-91810: Expand ElementTree.write() tests to use non-ASCII data (
74fec20 
pythonGH-91989)

(cherry picked from commit f60b4c3)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 27, 2022
@serhiy-storchaka
[3.9] pythongh-91810: Expand ElementTree.write() tests to use non-ASC…
ece063d 
…II data (pythonGH-91989).

(cherry picked from commit f60b4c3)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Apr 27, 2022

Copy link
Copy Markdown

GH-91994 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Apr 27, 2022
miss-islington added a commit that referenced this pull request Apr 27, 2022
@miss-islington @serhiy-storchaka
gh-91810: Expand ElementTree.write() tests to use non-ASCII data (GH-…
777d478 
…91989)

(cherry picked from commit f60b4c3)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Apr 27, 2022
@serhiy-storchaka
[3.9] gh-91810: Expand ElementTree.write() tests to use non-ASCII data (
993bb16 
GH-91989). (GH-91994)

(cherry picked from commit f60b4c3)
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@serhiy-storchaka @hello-adam
[3.9] pythongh-91810: Expand ElementTree.write() tests to use non-ASC…
8d2b4c0 
…II data (pythonGH-91989). (pythonGH-91994)

(cherry picked from commit f60b4c3)
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.