GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-87390: Add __unpacked__ attribute to types.GenericAlias by JelleZijlstra · Pull Request #92059 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Apr 29, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

#87390

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-87390: Add __unpacked__ attribute to types.GenericAlias
63d2d80
@bedevere-bot bedevere-bot added the awaiting core review label Apr 29, 2022
@JelleZijlstra

JelleZijlstra commented Apr 29, 2022

Copy link
Copy Markdown
Member Author

cc @mrahtz
mrahtz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra requested a review from Fidget-Spinner April 30, 2022 03:14
@mrahtz mrahtz mentioned this pull request May 2, 2022
Add support for PEP 646 #87390
Closed
Fidget-Spinner
Fidget-Spinner reviewed May 2, 2022
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs need fixing up, otherwise code LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/types.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra added 2 commits May 2, 2022 08:49
@JelleZijlstra
Merge remote-tracking branch 'upstream/main' into gaunpacked
c0b649c
@JelleZijlstra
move to the existing docs
81cbc83
Fidget-Spinner
Fidget-Spinner approved these changes May 2, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 2, 2022
@JelleZijlstra
JelleZijlstra merged commit ff88f7e into python:main May 2, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 2, 2022
@JelleZijlstra
JelleZijlstra deleted the gaunpacked branch May 2, 2022 19:22
JelleZijlstra added a commit to python/typeshed that referenced this pull request May 3, 2022
@JelleZijlstra
Add GenericAlias.__unpacked__
68e4a84 
python/cpython#92059
@JelleZijlstra JelleZijlstra mentioned this pull request May 3, 2022
Add GenericAlias.__unpacked__ python/typeshed#7774
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JelleZijlstra @Fidget-Spinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.