GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-89452: Prefer gdbm-compat over ndbm by ambv · Pull Request #92208 · python/cpython

Conversation

@ambv

@ambv ambv commented May 3, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This makes macOS gdbm provided by Homebrew not segfault through correct
selection of the linked library (-lgdbm_compat) AND the correct ndbm-style
header (gdbm-ndbm.h instead of the invalid ndbm.h).

Addresses #89452.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ambv
pythongh-89452: Prefer gdbm-compat over ndbm
f360ff5 
This makes macOS gdbm provided by Homebrew not segfault through correct
selection of the linked library (-lgdbm_compat) *AND* the correct ndbm-style
header (gdbm-ndbm.h instead of the invalid ndbm.h).
@bedevere-bot bedevere-bot added the awaiting core review label May 3, 2022
@ambv ambv added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 3, 2022
@bedevere-bot

bedevere-bot commented May 3, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ambv for commit f360ff5 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 3, 2022
ambv
ambv commented May 3, 2022
View reviewed changes
Comment thread Modules/_dbmmodule.c
static const char which_dbm[] = "GNU gdbm";
#elif defined(USE_NDBM)
#include <ndbm.h>
static const char which_dbm[] = "GNU gdbm";

@ambv ambv May 3, 2022

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the now stale comment about the OS/2 "EMX port" that was added over 20 years ago.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ambv
ambv requested review from ned-deily and tiran May 3, 2022 01:42
@ambv ambv linked an issue May 3, 2022 that may be closed by this pull request
test_dbm and test_dbm_ndbm segfaults in M1 Mac with Homebrew gdbm 1.23 #89452
Closed
@ambv ambv removed a link to an issue May 3, 2022
test_dbm and test_dbm_ndbm segfaults in M1 Mac with Homebrew gdbm 1.23 #89452
Closed
@ambv

ambv commented May 3, 2022

Copy link
Copy Markdown
Contributor Author

(I unlinked the PR from the issue because I don't want the PR to close the issue. We need backports first.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ned-deily
ned-deily approved these changes May 3, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 3, 2022
@ambv

ambv commented May 3, 2022

Copy link
Copy Markdown
Contributor Author

The two failing RHEL7 buildbots are SIGABRT of an embed process due to an assertion failure like:

_testembed: Python/specialize.c:266: _PyCode_Quicken: Assertion `instructions[i + 1] == 0' failed.

This doesn't look related to my changes here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv added needs backport to 3.9 labels May 3, 2022
@ambv
ambv merged commit 6c25bf0 into python:main May 3, 2022
@miss-islington

miss-islington commented May 3, 2022

Copy link
Copy Markdown
Contributor

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 3, 2022
@miss-islington

miss-islington commented May 3, 2022

Copy link
Copy Markdown
Contributor

Sorry, @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6c25bf07e86b6d8d5e50488835f70539f382d7e0 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned ambv May 3, 2022
@miss-islington

miss-islington commented May 3, 2022

Copy link
Copy Markdown
Contributor

Sorry @ambv, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6c25bf07e86b6d8d5e50488835f70539f382d7e0 3.9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv deleted the gh89452 branch May 3, 2022 16:28
@ambv
ambv restored the gh89452 branch May 3, 2022 16:41
@ambv
ambv deleted the gh89452 branch May 3, 2022 16:41
@ambv

ambv commented May 3, 2022

Copy link
Copy Markdown
Contributor Author

OK, looks like the build-related changes made by Christian in #29467 and #29720 were only made to 3.11 so I'm aborting backports here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv removed needs backport to 3.9 labels May 3, 2022
@encukou encukou mentioned this pull request Oct 8, 2024
test_dbm and test_dbm_ndbm segfaults in M1 Mac with Homebrew gdbm 1.23 #89452
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ambv ambv

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ambv @bedevere-bot @miss-islington @ned-deily
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.