GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45847: Port _gdbm to PY_STDLIB_MOD (GH-29720) by tiran · Pull Request #29720 · python/cpython

Conversation

@tiran

@tiran tiran commented Nov 23, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue45847

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 23, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Nov 23, 2021
@tiran tiran added the skip news label Nov 23, 2021
@tiran
bpo-45847: Port _gdbm to PY_STDLIB_MOD
f7e0372 
Signed-off-by: Christian Heimes <[email protected]>
@tiran
tiran force-pushed the bpo-45847-gdbm branch from d418618 to f7e0372 Compare November 23, 2021 09:28
@tiran
tiran requested a review from erlend-aasland November 23, 2021 10:53
erlend-aasland
erlend-aasland approved these changes Nov 23, 2021
View reviewed changes
Comment thread configure.ac
[ndbm], [],
[gdbm], [have_gdbm_dbmliborder=yes],
[bdb], [],
[with_dbmliborder=error]

@erlend-aasland erlend-aasland Nov 23, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just put AC_MSG_ERROR here, avoiding the AS_VAR_IF below, but I'm fine with this variant as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@tiran tiran Nov 23, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it. For unknown reasons it does not work. I get a bunch of shell error messages when the error case is triggered.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with eyes emoji
All reactions
  • 👀 1 reaction
Comment thread configure.ac
Comment on lines +3380 to +3381
as_save_IFS=$IFS
IFS=:

@erlend-aasland erlend-aasland Nov 23, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, why do we save IFS here? AFAICS, there's nothing touching it, but I may be mistaken.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@tiran tiran Nov 23, 2021

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm saving and setting IFS here so the for loop uses : as a field separator.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@erlend-aasland erlend-aasland Nov 23, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, just found it in the man page. Learned something new today.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@tiran tiran changed the title bpo-45847: Port _gdbm to PY_STDLIB_MOD bpo-45847: Port _gdbm to PY_STDLIB_MOD (GH-29720) Nov 23, 2021
@tiran
tiran merged commit 9cf5646 into python:main Nov 23, 2021
@tiran
tiran deleted the bpo-45847-gdbm branch November 23, 2021 21:58
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 23, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
@tiran remykarem
bpo-45847: Port _gdbm to PY_STDLIB_MOD (pythonGH-29720)
fdd7f3e
@tiran tiran mentioned this pull request Apr 14, 2022
Port module setup to PY_STDLIB_MOD() macro and addext() #90005
Closed
@ambv ambv mentioned this pull request May 3, 2022
gh-89452: Prefer gdbm-compat over ndbm #92208
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @erlend-aasland @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.