GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.8] gh-80254: Disallow recursive usage of cursors in sqlite3 converters by erlend-aasland · Pull Request #92333 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 5, 2022

Copy link
Copy Markdown
Contributor

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev [email protected]
Co-authored-by: Jelle Zijlstra [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
erlend-aasland and others added 3 commits May 4, 2022 23:47
@erlend-aasland @sir-sigurd @JelleZijlstra
[3.8] pythongh-80254: Disallow recursive usage of cursors in `sqlite3…
2dc3259 
…` converters

(cherry picked from commit c908dc5)

Co-authored-by: Sergey Fedoseev <[email protected]>
Co-authored-by: Jelle Zijlstra <[email protected]>
@erlend-aasland
Fix ref leak in pysqlite_cursor_iternext
fc07267
@erlend-aasland
Explicitly free resources at test tearDown()
88b09dc
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner May 5, 2022 12:11
@bedevere-bot bedevere-bot added the awaiting review label May 5, 2022
@erlend-aasland
erlend-aasland requested review from JelleZijlstra and ambv May 5, 2022 12:11
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022
@bedevere-bot

bedevere-bot commented May 5, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 88b09dc 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 5, 2022
Tony-Frank-ML
Tony-Frank-ML approved these changes May 5, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 5, 2022
This was referenced May 5, 2022
gh-80254: Disallow recursive usage of cursors in sqlite3 converters #29054
Merged
sqlite crashes with converters mutating cursor #80254
Closed
@erlend-aasland

erlend-aasland commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

Buildbot comments (updating this post as they complete):

  • AMD64 FreeBSD Shared PR: compile failures; seems unrelated to this PR
  • ARM64 Windows PR: build tools missing; unrelated
  • ARM64 Windows Non-Debug PR: build tools missing; unrelated
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented May 5, 2022

Copy link
Copy Markdown
Member

The remaining failures (Gentoo, Fedora, Asan, Usan) are also on tests unrelated to SQLite. I don't have permissions to merge to this branch though.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra approved these changes May 5, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 5, 2022
@erlend-aasland

erlend-aasland commented May 5, 2022

Copy link
Copy Markdown
Contributor Author

FTR, the buildbot failures all seem unrelated. Some are failed builds (missing build tools), others are unrelated test failures.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 5, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The 3.8 branch no longer accept bugfixes, only security fixes: https://devguide.python.org/#status-of-python-branches

Do you consider that this change fix a security issue?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented May 5, 2022

Copy link
Copy Markdown
Member

The 3.8 branch no longer accept bugfixes, only security fixes: https://devguide.python.org/#status-of-python-branches

Do you consider that this change fix a security issue?

Yes, because it fixes a segfault. #29054 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 5, 2022

Copy link
Copy Markdown
Member

Ok, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 69cf020 into python:3.8 May 16, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 16, 2022
@erlend-aasland
erlend-aasland deleted the backport-sqlite-converter-segfault-3.8 branch May 16, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner
@ambv ambv Awaiting requested review from ambv
+1 more reviewer
@Tony-Frank-ML Tony-Frank-ML Tony-Frank-ML approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@erlend-aasland @bedevere-bot @JelleZijlstra @vstinner @Tony-Frank-ML @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.