GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||
GeezerVison is showing github.com — gh-80254: Disallow recursive usage of cursors in `sqlite3` converters by erlend-aasland · Pull Request #29054 · python/cpython Conversation
|
|
🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit bb0a729 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Buildbot comments:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
On hold until end of week: #29054 (comment) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@erlend-aasland, sorry for delay, I closed my PR. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
sqlite3 converterssqlite3 converters
|
I think it would be a good idea to mention in the Docs. If already there please show ref. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
@MaxwellDupre, can you please explain why? I think we should not try to encourage users to shoot themselves in the foot with adapters and converters (or at all), so I prefer, very strongly, not to mention this in the docs. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry @erlend-aasland and @JelleZijlstra, I had trouble checking out the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'll fix the backports |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks! I think it should go into the security branches too, because every segfault is potentially an exploitable security issue. @ambv what do you think? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…3` converters (python#29054) (cherry picked from commit f629dcf) Co-authored-by: Sergey Fedoseev <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]>
|
@JelleZijlstra, correct! Crashers are DoS and as such are treated as security issues. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @erlend-aasland for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @erlend-aasland and @JelleZijlstra, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry @erlend-aasland and @JelleZijlstra, I had trouble checking out the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Thanks for that fact regarding crashers, I was unaware! 📝 I'll fix the backports as soon as possible (currently on my way back home from pycon). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks! I looked at the 3.10 backport for a while but I'm not sure where the refleak is. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
No worries, I found and fixed it in flight to Chicago. I've yet to push it though. But 3.9 contains even more ref. leaks! Looking into that soon. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
FTR (also cross-posting this list on the issue):
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…verters (#92274) * [3.10] gh-80254: Disallow recursive usage of cursors in `sqlite3` converters (#29054) (cherry picked from commit f629dcf) Co-authored-by: Sergey Fedoseev <[email protected]> Co-authored-by: Jelle Zijlstra <[email protected]> * Fix ref leak in pysqlite_cursor_iternext
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
sqlite crashes with converters mutating cursor
There was an error while loading. Please reload this page.