GeezerVison

Original file line number	Diff line number	Diff line change
Expand Up		@@ -512,6 +512,10 @@ Pending Removal in Python 3.14
		:func:`~multiprocessing.set_start_method` APIs to explicitly specify when
		your code requires ``'fork'``. See :ref:`multiprocessing-start-methods`.

		* :mod:`pty` has two undocumented ``master_open()`` and ``slave_open()``
		functions that have been deprecated since Python 2 but only gained a
		proper :exc:`DeprecationWarning` in 3.12. Remove them in 3.14.

		Pending Removal in Future Versions
		----------------------------------

Expand Down

20 changes: 7 additions & 13 deletions 20 Lib/pty.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -40,6 +40,9 @@ def master_open():
		Open a pty master and return the fd, and the filename of the slave end.
		Deprecated, use openpty() instead."""

		import warnings
		warnings.warn("Use pty.openpty() instead.", DeprecationWarning, stacklevel=2) # Remove API in 3.14

		try:
		master_fd, slave_fd = os.openpty()
		except (AttributeError, OSError):
Expand Down Expand Up		@@ -69,6 +72,9 @@ def slave_open(tty_name):
		opened filedescriptor.
		Deprecated, use openpty() instead."""

		import warnings
		warnings.warn("Use pty.openpty() instead.", DeprecationWarning, stacklevel=2) # Remove API in 3.14

		result = os.open(tty_name, os.O_RDWR)
		try:
		from fcntl import ioctl, I_PUSH
Expand Down Expand Up		@@ -101,20 +107,8 @@ def fork():
		master_fd, slave_fd = openpty()
		pid = os.fork()
		if pid == CHILD:
		# Establish a new session.
		os.setsid()
		os.close(master_fd)

		# Slave becomes stdin/stdout/stderr of child.
		os.dup2(slave_fd, STDIN_FILENO)
		os.dup2(slave_fd, STDOUT_FILENO)
		os.dup2(slave_fd, STDERR_FILENO)
		if slave_fd > STDERR_FILENO:
		os.close(slave_fd)

		# Explicitly open the tty to make it become a controlling tty.
		tmp_fd = os.open(os.ttyname(STDOUT_FILENO), os.O_RDWR)
		os.close(tmp_fd)
		os.login_tty(slave_fd)
		else:
		os.close(slave_fd)

Expand Down

4 changes: 4 additions & 0 deletions 4 Misc/NEWS.d/next/Library/2023-02-05-21-40-15.gh-issue-85984.Kfzbb2.rst

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,4 @@
		Refactored the implementation of :func:`pty.fork` to use :func:`os.login_tty`.

		A :exc:`DeprecationWarning` is now raised by ``pty.master_open()`` and ``pty.slave_open()``. They were
		undocumented and deprecated long long ago in the docstring in favor of :func:`pty.openpty`.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.