GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-76773: Update docs mentioning no-longer-supported Windows versions & features by CAM-Gerlach · Pull Request #92529 · python/cpython

Conversation

@CAM-Gerlach

@CAM-Gerlach CAM-Gerlach commented May 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In #76773 , I compiled a detailed list of places where currently or (then-)to-be-unsupported Windows versions were referred to in the context of being current, with a focus on documentation. Unfortunately, as the issue became mired for a time in debates about whether and when it was necessary to drop Windows <8.1 support, I was never able to follow up and update them.

Support for Windows <8.1 was broken in PR #18231 to fix issue #83582 (CVE-2020-8315), dropped officially (albeit rather unceremoniously, with only a short news entry and without documentation updates) in @zooba 's PR #21656 to resolve issue #85584 and clarified a bit at least in the "Using Python on Windows" document in PR #23603 addressing issue #42523 . However, it appears that besides that, few of the others enumerated there were actually updated.

Therefore, this PR updates them, as well as a handful of other mentions I found in the process. In particular, it:

  • Corrects statements of the supported Windows and MSVC versions to accurately reflect this
  • Elides mentions of long-obsolete/unsupported Windows versions, compilers and distributions
  • Revises a few other related bits in the documentation that had drifted out of date.
  • Fixes numerous broken and out of date links in the above Windows-related sections
  • Opportunistically updates references to long-EoL Python versions where already modifying nearby content

All of the changes should be backport-safe since the removed/updated portions are mostly long-obsolete and support for Windows <8.1 was dropped in Python 3.9, the earliest version still accepting bugfix PRs; I avoided any changes that were potentially version-specific or referred to anything 3.9 or later.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
CAM-Gerlach added 6 commits May 8, 2022 21:50
@CAM-Gerlach
qh-76773: Update/remove obselete parts of the Windows guide
12808fb
@CAM-Gerlach
qh-76773: Update outdated links in the Python on Windows guide
4501df5
@CAM-Gerlach
qh-76773: Update mentions of obselete Python versions in Windows guide
e880a15
@CAM-Gerlach
qh-76773: Update refs to ancient Windows versions in PC/PCBuild READMEs
f84fbbf
@CAM-Gerlach
qh-76773: Update outdated/broken links in PC/PCBuild READMEs
c17f901
@CAM-Gerlach
qh-76773: Update misc docs mentioning obselete DOS, WinCE & Borland
234aa3c
@bedevere-bot bedevere-bot added the awaiting review label May 9, 2022
@CAM-Gerlach CAM-Gerlach added docs Documentation in the Doc dir OS-windows skip news needs backport to 3.9 needs backport to 3.11 only security fixes labels May 9, 2022
@CAM-Gerlach
CAM-Gerlach marked this pull request as ready for review May 9, 2022 05:26
@CAM-Gerlach
CAM-Gerlach requested a review from a team as a code owner May 9, 2022 05:26
@CAM-Gerlach
CAM-Gerlach requested a review from zooba May 9, 2022 05:27
serhiy-storchaka
serhiy-storchaka reviewed May 9, 2022
View reviewed changes
Comment thread Doc/faq/windows.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/using/windows.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/using/windows.rst Outdated
::

py -2
py -3

@serhiy-storchaka serhiy-storchaka May 9, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks superfluous. Just py starts the latest Python version, and currently it is the latest Python 3 version.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@CAM-Gerlach CAM-Gerlach May 9, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks. Would you like me to revert the change to keep py -2, or elide the whole mention as superflous?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@brettcannon brettcannon May 10, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as there is an example of using py you can leave it as it's a feature that is still supported.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

@serhiy-storchaka serhiy-storchaka May 10, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I interpret it as you can leave py -2.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@CAM-Gerlach CAM-Gerlach May 10, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks. I reverted it to that, and also cleaned up the reST code block syntax on or near the lines I touched.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/using/windows.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/using/windows.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
serhiy-storchaka requested a review from brettcannon May 9, 2022 15:08
zooba
zooba reviewed May 9, 2022
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections, but not ready to merge yet

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/using/windows.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread PCbuild/readme.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.

@CAM-Gerlach
qh-76773: Elide/use consistant Win/MSVC/Py versions in Win docs
637ce8e
@CAM-Gerlach
CAM-Gerlach requested review from serhiy-storchaka and zooba May 9, 2022 20:55
zooba
zooba approved these changes May 9, 2022
View reviewed changes

@zooba zooba left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not sure if anyone else is reviewing, so I won't merge immediately

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 9, 2022
brettcannon
brettcannon approved these changes May 10, 2022
View reviewed changes
Comment thread Doc/using/windows.rst Outdated
::

py -2
py -3

@brettcannon brettcannon May 10, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as there is an example of using py you can leave it as it's a feature that is still supported.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@CAM-Gerlach
qh-76773: Revert py ver change 1 place in win doc & clean up code blocks
34e1254
serhiy-storchaka
serhiy-storchaka approved these changes May 10, 2022
View reviewed changes
@serhiy-storchaka
serhiy-storchaka merged commit f1bbcba into python:main May 10, 2022
@miss-islington

miss-islington commented May 10, 2022

Copy link
Copy Markdown
Contributor

Thanks @CAM-Gerlach for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed awaiting merge needs backport to 3.11 only security fixes labels May 10, 2022
@bedevere-bot

bedevere-bot commented May 10, 2022

Copy link
Copy Markdown

GH-92608 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented May 10, 2022

Copy link
Copy Markdown

GH-92609 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed needs backport to 3.10 labels May 10, 2022
@bedevere-bot

bedevere-bot commented May 10, 2022

Copy link
Copy Markdown

GH-92610 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2022
@CAM-Gerlach @miss-islington
pythongh-76773: Update docs mentioning no-longer-supported Windows ve…
1af5ce8
…rsions & features (pythonGH-92529)

(cherry picked from commit f1bbcba)

Co-authored-by: CAM Gerlach <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2022
@CAM-Gerlach @miss-islington
pythongh-76773: Update docs mentioning no-longer-supported Windows ve…
95e3410
…rsions & features (pythonGH-92529)

(cherry picked from commit f1bbcba)

Co-authored-by: CAM Gerlach <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 10, 2022
@CAM-Gerlach @miss-islington
pythongh-76773: Update docs mentioning no-longer-supported Windows ve…
a04378a
…rsions & features (pythonGH-92529)

(cherry picked from commit f1bbcba)

Co-authored-by: CAM Gerlach <[email protected]>
miss-islington added a commit that referenced this pull request May 10, 2022
@miss-islington
[3.10] gh-76773: Update docs mentioning no-longer-supported Windows v…
dd0e8a6
…ersions & features (GH-92529) (GH-92609)

(cherry picked from commit f1bbcba)


Co-authored-by: CAM Gerlach <[email protected]>

Automerge-Triggered-By: GH:serhiy-storchaka
miss-islington added a commit that referenced this pull request May 10, 2022
@miss-islington
[3.9] gh-76773: Update docs mentioning no-longer-supported Windows ve…
7534c50
…rsions & features (GH-92529) (GH-92610)

(cherry picked from commit f1bbcba)


Co-authored-by: CAM Gerlach <[email protected]>

Automerge-Triggered-By: GH:serhiy-storchaka
miss-islington added a commit that referenced this pull request May 10, 2022
@miss-islington
[3.11] gh-76773: Update docs mentioning no-longer-supported Windows v…
635b62a
…ersions & features (GH-92529) (GH-92608)

(cherry picked from commit f1bbcba)


Co-authored-by: CAM Gerlach <[email protected]>

Automerge-Triggered-By: GH:serhiy-storchaka
@CAM-Gerlach CAM-Gerlach mentioned this pull request May 13, 2022
Doc: Update references and examples of old, unsupported OSes and uarches #92791
Merged
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @hello-adam
[3.9] pythongh-76773: Update docs mentioning no-longer-supported Wind…
ff1a418
…ows versions & features (pythonGH-92529) (pythonGH-92610)

(cherry picked from commit f1bbcba)


Co-authored-by: CAM Gerlach <[email protected]>

Automerge-Triggered-By: GH:serhiy-storchaka
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@zooba zooba zooba approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir OS-windows skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@CAM-Gerlach @miss-islington @bedevere-bot @brettcannon @zooba @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.