GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91491: Complete Whats New in 3.11 for typing by JelleZijlstra · Pull Request #92708 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented May 12, 2022

Copy link
Copy Markdown
Member

Fixes #91491

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra
pythongh-91491: Complete Whats New in 3.11 for typing
0a9eb32 
Fixes python#91491
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels May 12, 2022
@JelleZijlstra JelleZijlstra added the skip news label May 12, 2022
@JelleZijlstra
JelleZijlstra marked this pull request as draft May 12, 2022 03:07
hauntsaninja
hauntsaninja reviewed May 12, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added the topic-typing label May 12, 2022
Fidget-Spinner
Fidget-Spinner reviewed May 12, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.11.rst
Comment on lines +754 to +756
* Loosen runtime requirements for type annotations by removing the callable
check in the private ``typing._type_check`` function. (Contributed by
Gregory Beauregard in :gh:`90802`.)

@Fidget-Spinner Fidget-Spinner May 12, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we really include this? It's a private undocumented function (though David's recent bug report suggested to me otherwise).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra May 12, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that it's already spawned a bug report, it's likely that other users will run into this change, so I think it's important to include.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood and Fidget-Spinner reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

@Fidget-Spinner Fidget-Spinner May 12, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed then. Could you please add a notice strongly discouraging users from using it too? We might as well try to dissuade users though it might be in vain :).

This function is for internal use only and is **unstable** and may change across versions. Please do not use this function. Instead, we recommend implementing this with your own code.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@JelleZijlstra JelleZijlstra May 17, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That feels like a bit much for the What's New document. We should say what changed, but I don't think we need more than that.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JelleZijlstra @hauntsaninja
Update Doc/whatsnew/3.11.rst
c0d95b4 
Co-authored-by: Shantanu <[email protected]>
@JelleZijlstra
JelleZijlstra marked this pull request as ready for review May 12, 2022 14:22
AlexWaygood
AlexWaygood reviewed May 12, 2022
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra added 2 commits May 17, 2022 06:44
@JelleZijlstra
Merge branch 'main' into whatsnew
b244db8
@JelleZijlstra
feedback
8798089
AlexWaygood
AlexWaygood reviewed May 17, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra @AlexWaygood
Update Doc/whatsnew/3.11.rst
c242df1 
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
AlexWaygood approved these changes May 18, 2022
View reviewed changes
Fidget-Spinner
Fidget-Spinner approved these changes May 19, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 19, 2022
@JelleZijlstra JelleZijlstra added the needs backport to 3.11 only security fixes label May 19, 2022
@JelleZijlstra
JelleZijlstra merged commit 6b51773 into python:main May 19, 2022
@miss-islington

miss-islington commented May 19, 2022

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 19, 2022
@miss-islington

miss-islington commented May 19, 2022

Copy link
Copy Markdown
Contributor

Sorry @JelleZijlstra, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6b51773afd5658e15d23ce220f66fcc39c02dcae 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra deleted the whatsnew branch May 19, 2022 14:07
@miss-islington miss-islington assigned JelleZijlstra May 19, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels May 19, 2022
@miss-islington

miss-islington commented May 19, 2022

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
@JelleZijlstra @miss-islington
pythongh-91491: Complete Whats New in 3.11 for typing (pythonGH-92708)
fdb36c2 
Fixes pythonGH-91491

Co-authored-by: Shantanu <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 6b51773)

Co-authored-by: Jelle Zijlstra <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 19, 2022
@bedevere-bot

bedevere-bot commented May 19, 2022

Copy link
Copy Markdown

GH-92958 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request May 19, 2022
@miss-islington @JelleZijlstra
gh-91491: Complete Whats New in 3.11 for typing (GH-92708)
611d43c 
Fixes GH-91491

Co-authored-by: Shantanu <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 6b51773)

Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja left review comments
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

docs Documentation in the Doc dir skip news topic-typing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add typing to 3.11 What's New

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@JelleZijlstra @miss-islington @bedevere-bot @hauntsaninja @Fidget-Spinner @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.