GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92611: Clarify planned removal version in PEP 594-deprecated modules by CAM-Gerlach · Pull Request #92793 · python/cpython

Conversation

@CAM-Gerlach

@CAM-Gerlach CAM-Gerlach commented May 14, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

As discussed in #92611 and #92564 and as a followup to PR #92612 , this 3.11+ only PR uses the proper deprecated-removed role for the modules deprecated by PEP 593 (PEP-594) to clearly indicate to users that a removal version is planned and what it is, so they can prepare accordingly or voice any unanticipated impacts.

Related to #92792 ; if we decide to backport that PR, the upgrade to using deprecated-removed on those functions can be moved to this one.

Automerge-Triggered-By: GH:brettcannon

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@CAM-Gerlach
pythongh-92611: Clarify planned removal version in PEP 594-deprecated…
579c25d 
… modules
@CAM-Gerlach
CAM-Gerlach requested review from a team and ethanfurman as code owners May 14, 2022 00:05
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 14, 2022
@CAM-Gerlach CAM-Gerlach added skip news needs backport to 3.11 only security fixes labels May 14, 2022
@CAM-Gerlach
CAM-Gerlach requested review from brettcannon and removed request for a team and ethanfurman May 14, 2022 00:05
carljm
carljm approved these changes May 17, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels May 17, 2022
brettcannon
brettcannon approved these changes May 20, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 20, 2022
@brettcannon brettcannon added the 🤖 automerge label May 20, 2022
@miss-islington
miss-islington merged commit 31fa41e into python:main May 20, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 20, 2022
@miss-islington

miss-islington commented May 20, 2022

Copy link
Copy Markdown
Contributor

Thanks @CAM-Gerlach for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 20, 2022
@CAM-Gerlach @miss-islington
pythongh-92611: Clarify planned removal version in PEP 594-deprecated…
5c91c57 
… modules (pythonGH-92793)

As discussed in pythonGH-92611 and pythonGH-92564 and as a followup to PR pythonGH-92612 , this 3.11+ only PR uses the proper `deprecated-removed` role for the modules deprecated by PEP 593 (PEP-594) to clearly indicate to users that a removal version is planned and what it is, so they can prepare accordingly or voice any unanticipated impacts.

Related to pythonGH-92792 ; if we decide to backport that PR, the upgrade to using `deprecated-removed` on those functions can be moved to this one.
(cherry picked from commit 31fa41e)

Co-authored-by: CAM Gerlach <[email protected]>
@bedevere-bot

bedevere-bot commented May 20, 2022

Copy link
Copy Markdown

GH-93026 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 20, 2022
brettcannon pushed a commit that referenced this pull request May 20, 2022
@miss-islington @CAM-Gerlach
gh-92611: Clarify planned removal version in PEP 594-deprecated modul…
24223ec 
…es (GH-92793) (GH-93026)

As discussed in GH-92611 and GH-92564 and as a followup to PR GH-92612 , this 3.11+ only PR uses the proper `deprecated-removed` role for the modules deprecated by PEP 593 (PEP-594) to clearly indicate to users that a removal version is planned and what it is, so they can prepare accordingly or voice any unanticipated impacts.

Related to GH-92792 ; if we decide to backport that PR, the upgrade to using `deprecated-removed` on those functions can be moved to this one.
(cherry picked from commit 31fa41e)

Co-authored-by: CAM Gerlach <[email protected]>
rhettinger pushed a commit to rhettinger/cpython that referenced this pull request Jul 7, 2022
@CAM-Gerlach @rhettinger
pythongh-92611: Clarify planned removal version in PEP 594-deprecated…
dffb9a9 
… modules (pythonGH-92793)

As discussed in python#92611 and python#92564 and as a followup to PR python#92612 , this 3.11+ only PR uses the proper `deprecated-removed` role for the modules deprecated by PEP 593 (PEP-594) to clearly indicate to users that a removal version is planned and what it is, so they can prepare accordingly or voice any unanticipated impacts.

Related to python#92792 ; if we decide to backport that PR, the upgrade to using `deprecated-removed` on those functions can be moved to this one.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@carljm carljm carljm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@CAM-Gerlach @miss-islington @bedevere-bot @brettcannon @carljm
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.