GeezerVison

LGTM and I'm also +1 for this, but I'll wait to see what the rest have to say.

Thanks, could you check whether there's any usage of these remaining in the wild? (cf. #92547 (comment))

Thanks, could you check whether there's any usage of these remaining in the wild? (cf. #92547 (comment))

Is there an easy way to do this? From what I understand, the scripts need a local copy of PyPI.

When can we start deprecating typing.Pattern/Match and the io classes in typing?

I'm usually in the "sooner better than later" camp, but for now I wouldn't recommend to more than soft-deprecate those, until Python 3.8 goes end of life. 3.9 introduced the generics in the stdlib, so to write code compatible with 3.8 and 3.9+, you'd need to use a conditional import otherwise.

I also agree with @JelleZijlstra that we should check how much these are used in the wild before removing them, especially since we've never emitted DeprecationWarnings for these.

We do emit DeprecationWarnings, starting with Python 3.11.

I'd still like to double-check that there aren't too many uses of these in the wild, but providing there aren't, looks good!

Sounds like a good idea, if someone can do it and give me guidance on how to do it.

I think @vstinner has a script to get the top 5k, but I can't find it documented.

I wrote a different script: https://github.com/faster-cpython/tools/blob/main/scripts/download_packages.py

I think @vstinner has a script to get the top 5k, but I can't find it documented.

I just documented it in my doc: https://pythondev.readthedocs.io/test_next_python.html#top-5000-pypi-packages

I wrote these scripts for my own needs. It's based the script that @methane wrote to see how the PyUnicode C API was used.

For example, search_pypi_top.py ignores Cython files (use --cython option to not exclude them: see --help). Previously, I used rg for code serach, but it doesn't give the filename inside an archive and it doesn't show the matching line. Also, I needed something more specific to Python.

Thanks, @vstinner and @gvanrossum, that was very helpful! I did run Victor's script for the top 5000 packages, and here are the results:

typing.re: Two affected projects (ignoring the typing backport):

• Replace typing.re import ktbyers/netmiko#2788
• Replace typing.re import wemake-services/wemake-python-styleguide#2414

A quick count show 7 affected projects for typing.io. I will send PRs later.

typing.io:

• [Bug] Obsolete typing.io import hydra-ecosystem/hydra#2218
• Remove obsolete typing.io import cognitedata/cognite-sdk-python#922
• Vendored importlib_resources uses obsolete typing.io import pypa/pipenv#5106
• Generated files use obsolete typing.io import hydra-ecosystem/omegaconf#936
• stix-patterns conditionally imports typing.io only on Python < 3.6.
• Same for antlr4-python3-runtime
• amazon-dax-client doesn't seem to have a public bug tracker, so I consider this Amazon's problem

Ignoring a Python 2 package and the typing backport.

This makes for a total of 7 out of 5000 affected projects or 0.14%.

@vstinner You mean beyond the PRs and issues linked above? typing.re and typing.io hasn't been necessary since at least Python 3.6, if ever. I don't think typeshed ever supported those namespaces.

As far as I can tell we emit a DeprecationWarning only on 3.11, not 3.10. Therefore, following https://peps.python.org/pep-0387/#making-incompatible-changes we should wait until 3.13, not 3.12, to remove these.

In that case we need to retroactively update the documentation, which says that they will be removed in Python 3.12.

I just documented it in my doc: https://pythondev.readthedocs.io/test_next_python.html#top-5000-pypi-packages

I wonder if there's any way to automate this, say, given some special tag for deprecation removals?

The "What's new" comment needs to be moved to the 3.13 document when it becomes available.

We're now ready to remove this in 3.13. @srittau do you want to update the PR?

Done, merged main and moved the NEWS entry in the process.