GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92871: Postpone the removal of typing.{io,re} to 3.13 by srittau · Pull Request #98958 · python/cpython

Conversation

@srittau

@srittau srittau commented Nov 1, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

See #92873 for background. Cc @JelleZijlstra

Needs backport to Python 3.9+.

  • Issue: Remove typing.io and typing.re #92871

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@srittau
Postpone the removal of typing.{io,re}
a6b2020
@srittau
srittau requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners November 1, 2022 12:18
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Nov 1, 2022
@srittau srittau changed the title gh-92873: Postpone the removal of typing.{io,re} gh-92871: Postpone the removal of typing.{io,re} Nov 1, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 1, 2022
Remove typing.io and typing.re #92871
Closed
@AlexWaygood

AlexWaygood commented Nov 1, 2022

Copy link
Copy Markdown
Member

Needs backport to Python 3.9+.

3.9 is now only receiving security-related updates, so we'll probably only be backporting to 3.10 and 3.11 :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Nov 1, 2022

Copy link
Copy Markdown
Member

We should probably also remove this line from the "What's New in Python 3.11" page:

cpython/Doc/whatsnew/3.11.rst

Line 1853 in 4564490

* The :class:`typing.io <typing.IO>` namespace

But maybe it would be better to do that in a separate PR, so that this one backports to 3.10 cleanly.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added needs backport to 3.10 needs backport to 3.11 only security fixes labels Nov 1, 2022
@AlexWaygood AlexWaygood changed the title gh-92871: Postpone the removal of typing.{io,re} gh-92871: Postpone the removal of typing.{io,re} to 3.13 Nov 1, 2022
@gvanrossum
gvanrossum removed their request for review November 1, 2022 17:44
JelleZijlstra
JelleZijlstra approved these changes Nov 2, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 2, 2022
@JelleZijlstra
JelleZijlstra merged commit 65d1407 into python:main Nov 2, 2022
@miss-islington

miss-islington commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @srittau for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 2, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 2, 2022
@srittau @miss-islington
pythongh-92871: Postpone the removal of typing.{io,re} to 3.13 (pytho…
07be05c 
…nGH-98958)

(cherry picked from commit 65d1407)

Co-authored-by: Sebastian Rittau <[email protected]>
@miss-islington

miss-islington commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, @srittau and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 65d1407737befc3e9430eda8ae14ab1c7f9d8c7a 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned JelleZijlstra Nov 2, 2022
@bedevere-bot

bedevere-bot commented Nov 2, 2022

Copy link
Copy Markdown

GH-98985 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 2, 2022
@bedevere-bot

bedevere-bot commented Nov 2, 2022

Copy link
Copy Markdown

GH-98986 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Nov 2, 2022
miss-islington added a commit that referenced this pull request Nov 2, 2022
@miss-islington @srittau
gh-92871: Postpone the removal of typing.{io,re} to 3.13 (GH-98958)
b2e28c8 
(cherry picked from commit 65d1407)

Co-authored-by: Sebastian Rittau <[email protected]>
@srittau
srittau deleted the typing-removals branch November 2, 2022 07:08
AlexWaygood pushed a commit that referenced this pull request Nov 2, 2022
@JelleZijlstra @srittau
[3.10] gh-92871: Postpone the removal of typing.{io,re} to 3.13 (GH-9…
e07086d 
…8958) (#98986)

[3.10] gh-92871: Postpone the removal of typing.{io,re} to 3.13 (GH-98958).
(cherry picked from commit 65d1407)

Co-authored-by: Sebastian Rittau <[email protected]>

Co-authored-by: Sebastian Rittau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@srittau @AlexWaygood @miss-islington @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.