GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92913: Clarify change to init config module_search_paths[_set] fields by zooba · Pull Request #92980 · python/cpython

Conversation

@zooba

@zooba zooba commented May 19, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #92913

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
pythongh-92913: Clarify change to init config module_search_paths[_se…
f24614b 
…t] fields
@bedevere-bot bedevere-bot added the awaiting core review label May 19, 2022
zooba added 2 commits May 19, 2022 18:05
@zooba
Add NEWS
2dce02e
@zooba
Fix doc
c3e8ac2
@zooba zooba added the needs backport to 3.11 only security fixes label May 19, 2022
@zooba
zooba merged commit 403d16f into python:main May 19, 2022
@miss-islington

miss-islington commented May 19, 2022

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label May 19, 2022
@zooba
zooba deleted the gh-92913 branch May 19, 2022 19:23
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 19, 2022
@zooba @miss-islington
pythongh-92913: Clarify changes to PyInitConfig.module_search_paths[_…
79df008 
…set] fields (pythonGH-92980)

(cherry picked from commit 403d16f)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 19, 2022
@bedevere-bot

bedevere-bot commented May 19, 2022

Copy link
Copy Markdown

GH-92982 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request May 19, 2022
@miss-islington @zooba
gh-92913: Clarify changes to PyInitConfig.module_search_paths[_set] f…
4eb2f40 
…ields (GH-92980)

(cherry picked from commit 403d16f)

Co-authored-by: Steve Dower <[email protected]>
freakboy3742
freakboy3742 reviewed May 19, 2022
View reviewed changes
Comment thread Doc/c-api/init_config.rst
/* Specify sys.path explicitly */
/* To calculate the default and then modify, finish initialization and
then use PySys_GetObject("path") to get the list. */
condig.module_search_paths_set = 1

@freakboy3742 freakboy3742 May 19, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two typos in this line: condig, and missing a trailing semicolon.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@zooba zooba May 23, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I was zoned out of my mind with fatigue/allergies when I did this PR, so I'm impressed this was the worst of it (it wasn't the worst of my whole day, unfortunately)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba zooba mentioned this pull request May 23, 2022
getpath miscalculates sys.path from second initialization with PYTHONHOME on Windows #91985
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Regression in sys.path construction behaviour of Py_InitializeFromConfig()

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zooba @miss-islington @bedevere-bot @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.