GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93117: Remove too large sqlite3 bigmemtest by erlend-aasland · Pull Request #93154 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented May 23, 2022

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-93117: Use correct size for sqlite3 deserialize bigmem test
feecd1f
@erlend-aasland
erlend-aasland requested a review from berkerpeksag as a code owner May 23, 2022 22:48
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels May 23, 2022
@erlend-aasland erlend-aasland linked an issue May 23, 2022 that may be closed by this pull request
test_sqlite3.test_dbapi: test_deserialize_too_much_data_64bit uses undefined size (and requires 24 Exabytes of RAM) #93117
Closed
@erlend-aasland erlend-aasland added the skip news label May 23, 2022
@erlend-aasland
erlend-aasland requested a review from serhiy-storchaka May 23, 2022 22:56
@erlend-aasland

erlend-aasland commented May 23, 2022

Copy link
Copy Markdown
Contributor Author

@serhiy-storchaka, is it worth it to keep this test? It requires an awefully huge buffer.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland changed the title gh-93117: Use correct size for sqlite3 deserialize bigmem test gh-93117: Use correct memuse for sqlite3 deserialize bigmem test May 23, 2022
@serhiy-storchaka

serhiy-storchaka commented May 25, 2022

Copy link
Copy Markdown
Member

This test is always skipped. There is no machine with 2**63 bytes of memory (modern architectures have limit of 52 bits for address), and unlikely will be in the nearest century.
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland changed the title gh-93117: Use correct memuse for sqlite3 deserialize bigmem test gh-93117: Remove too large sqlite3 bigmemtests May 25, 2022
@erlend-aasland
Address review: remove unlikely test
a48b03a
@erlend-aasland erlend-aasland changed the title gh-93117: Remove too large sqlite3 bigmemtests gh-93117: Remove too large sqlite3 bigmemtest May 25, 2022
@erlend-aasland

erlend-aasland commented May 25, 2022

Copy link
Copy Markdown
Contributor Author

Thanks Serhiy; I'll remove it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request May 25, 2022
test_sqlite3.test_dbapi: test_deserialize_too_much_data_64bit uses undefined size (and requires 24 Exabytes of RAM) #93117
Closed
serhiy-storchaka
serhiy-storchaka approved these changes May 25, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 25, 2022
@erlend-aasland
erlend-aasland merged commit db3ef0c into python:main May 25, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label May 25, 2022
@erlend-aasland
erlend-aasland deleted the sqlite-fix-bigmemtests branch May 25, 2022 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_sqlite3.test_dbapi: test_deserialize_too_much_data_64bit uses undefined size (and requires 24 Exabytes of RAM)

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.