Description

The-Compiler

opened on May 23, 2022

Issue body actions

Bug report

In a755124 (GH-26728, v3.11.0a7), @erlend-aasland added a test_deserialize_too_much_data_64bit, which would instantly raise a NameError for size if run:

cpython/Lib/test/test_sqlite3/test_dbapi.py

Lines 629 to 634 in b2694ab

	@unittest.skipUnless(sys.maxsize > 2**32, 'requires 64bit platform')
	@bigmemtest(size=2**63, memuse=3, dry_run=False)
	def test_deserialize_too_much_data_64bit(self):
	with memory_database() as cx:
	with self.assertRaisesRegex(OverflowError, "'data' is too large"):
	cx.deserialize(b"b" * size)

...however, it's never actually run, because it's skipped on machines with less than 24 Exabytes (!) of RAM:

test_deserialize_too_much_data_64bit (test.test_sqlite3.test_dbapi.SerializeTests.test_deserialize_too_much_data_64bit) ... skipped 'not enough memory: 25769803776.0G minimum needed'

(Found by running flake8 over Lib/ out of curiosity, see #93010 (comment))

Activity

1. The-Compiler

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on May 23, 2022
2. AlexWaygood

   added

   topic-sqlite3

   on May 23, 2022
3. erlend-aasland

   added

   testsTests in the Lib/test dirTests in the Lib/test dir

   on May 23, 2022
4. erlend-aasland

   added this to sqlite3 issueson May 23, 2022
5. erlend-aasland

   moved this to TODO: Bugs in sqlite3 issueson May 23, 2022
6. erlend-aasland commented on May 23, 2022

   

   erlend-aasland

   on May 23, 2022

   Contributor

   More actions

   Thanks for the report! Do you want to propose a PR, @The-Compiler?
7. The-Compiler commented on May 23, 2022

   

   The-Compiler

   on May 23, 2022

   ContributorAuthor

   More actions

   I'm afraid I have no idea how a proper fix would look like. Is the test really supposed to need exabytes of RAM? If so, it should probably just be removed altogether?
8. erlend-aasland

   added a commit that references this issue on May 23, 2022

   pythongh-93117: Use correct size for sqlite3 deserialize bigmem test

   feecd1f
9. erlend-aasland

   linked a pull request that will close this issuegh-93117: Remove too large sqlite3 bigmemtest #93154on May 23, 2022
10. erlend-aasland commented on May 25, 2022

    

    erlend-aasland

    on May 25, 2022

    Contributor

    More actions

    The test is not needed; see Serhiy's comment: #93154 (comment)
11. erlend-aasland

    closed this as completedin #93154on May 25, 2022
12. Repository owner moved this from TODO: Bugs to Done in sqlite3 issueson May 25, 2022
13. erlend-aasland

    added a commit that references this issue on May 25, 2022

    gh-93117: Remove too large sqlite3 bigmemtest (#93154)

    db3ef0c

Issue actions