GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.11] gh-92898: Enhance _testcppext test on cast to PyObject* (GH-93111) by miss-islington · Pull Request #93275 · python/cpython

Conversation

miss-islington commented May 26, 2022

Copy link

Copy Markdown

Contributor

Add StrongRef class.
Rename and reformat functions of the _Py_CAST() implementation.
(cherry picked from commit 20d30ba)

Co-authored-by: Victor Stinner [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-92898: Enhance _testcppext test on cast to PyObject* (python…

5846beb

…GH-93111)

* Add StrongRef class.
* Rename and reformat functions of the _Py_CAST() implementation.
(cherry picked from commit 20d30ba)

Co-authored-by: Victor Stinner <[email protected]>

bedevere-bot mentioned this pull request

May 26, 2022

gh-92898: Enhance _testcppext test on cast to PyObject* #93111

Merged

miss-islington commented May 26, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

1 similar comment

miss-islington commented May 26, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added skip news awaiting review labels

May 26, 2022

vstinner approved these changes

May 26, 2022

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting review labels

May 26, 2022

miss-islington commented May 26, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington merged commit 9303a5a into python:3.11

May 26, 2022

bedevere-bot removed the awaiting merge label

May 26, 2022

miss-islington deleted the backport-20d30ba-3.11 branch

May 26, 2022 23:39

Reviewers

vstinner

vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.