GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92898: Enhance _testcppext test on cast to PyObject* by vstinner · Pull Request #93111 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented May 23, 2022

Copy link
Copy Markdown
Member
  • Add StrongRef class.
  • Rename and reformat functions of the _Py_CAST() implementation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-92898: Enhance _testcppext test on cast to PyObject*
b5cf8b6 
* Add StrongRef class.
* Rename and reformat functions of the _Py_CAST() implementation.
@vstinner vstinner added skip news needs backport to 3.11 only security fixes labels May 23, 2022
@bedevere-bot bedevere-bot added the awaiting core review label May 23, 2022
@vstinner

vstinner commented May 23, 2022

Copy link
Copy Markdown
Member Author

I'm not sure that having a separated _Py_STATIC_CAST() macro is still needed with the new _Py_CAST() implementation. Maybe _Py_STATIC_CAST() can now be replaced with _Py_CAST().
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Add NEWS entry
84a18b4
@vstinner

vstinner commented May 23, 2022

Copy link
Copy Markdown
Member Author

I added a NEWS entry for #92951 change, since at least greenlet and scipy were impacted by C++ compiler warnings with Python 3.11 beta1.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request May 23, 2022
gh-92898: Make _Py_Cast C++ version compatible with cast operator #92951
Merged
@vstinner

vstinner commented May 23, 2022

Copy link
Copy Markdown
Member Author

cc @serge-sans-paille @corona10 @erlend-aasland @tacaswell
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 20d30ba into python:main May 26, 2022
@miss-islington

miss-islington commented May 26, 2022

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label May 26, 2022
@vstinner
vstinner deleted the cpp_cast branch May 26, 2022 23:12
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 26, 2022
@vstinner @miss-islington
pythongh-92898: Enhance _testcppext test on cast to PyObject* (python…
5846beb 
…GH-93111)

* Add StrongRef class.
* Rename and reformat functions of the _Py_CAST() implementation.
(cherry picked from commit 20d30ba)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 26, 2022
@bedevere-bot

bedevere-bot commented May 26, 2022

Copy link
Copy Markdown

GH-93275 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request May 26, 2022
@miss-islington @vstinner
gh-92898: Enhance _testcppext test on cast to PyObject* (GH-93111)
9303a5a 
* Add StrongRef class.
* Rename and reformat functions of the _Py_CAST() implementation.
(cherry picked from commit 20d30ba)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.