GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-92597: Ensure that AST nodes without explicit end positions can be compiled by pablogsal · Pull Request #93359 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented May 30, 2022

Copy link
Copy Markdown
Member

Closes: #92597

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
pablogsal added 3 commits May 30, 2022 18:37
@pablogsal
pythongh-92597: Ensure that AST nodes without explicit end positions …
df8934d 
…can be compiled
@pablogsal
Add NEWS entry
c0a3429
@pablogsal
fixup! Add NEWS entry
4fa8695
@pablogsal
pablogsal requested a review from isidentical as a code owner May 30, 2022 18:29
@pablogsal pablogsal added the needs backport to 3.11 only security fixes label May 30, 2022
@pablogsal
pablogsal requested a review from markshannon May 30, 2022 18:29
@bedevere-bot bedevere-bot added the awaiting core review label May 30, 2022
@pablogsal
pablogsal force-pushed the gh-92597 branch 4 times, most recently from 47bf959 to 4fa8695 Compare May 30, 2022 19:01
arhadthedev
arhadthedev reviewed May 30, 2022
View reviewed changes
Comment thread Parser/asdl_c.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
arhadthedev
arhadthedev reviewed May 30, 2022
View reviewed changes
Comment thread Parser/asdl_c.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal mentioned this pull request May 31, 2022
"Consistent AST position" crashes pytest: "ValueError: line 22-0 is not a valid range" #93387
Closed
@nedbat

nedbat commented May 31, 2022

Copy link
Copy Markdown
Member

I can confirm that this fixes #93387.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nedbat nedbat mentioned this pull request May 31, 2022
3.11.0b1 ValueError "not a valid range" pytest-dev/pytest#10008
Closed
@pablogsal
pablogsal merged commit 705eaec into python:main May 31, 2022
@pablogsal
pablogsal deleted the gh-92597 branch May 31, 2022 23:00
@miss-islington

miss-islington commented May 31, 2022

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label May 31, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 31, 2022
@pablogsal @miss-islington
pythongh-92597: Ensure that AST nodes without explicit end positions …
a3156c6 
…can be compiled (pythonGH-93359)

(cherry picked from commit 705eaec)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@bedevere-bot

bedevere-bot commented May 31, 2022

Copy link
Copy Markdown

GH-93397 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 31, 2022
miss-islington added a commit that referenced this pull request May 31, 2022
@miss-islington @pablogsal
gh-92597: Ensure that AST nodes without explicit end positions can be…
b425d88 
… compiled (GH-93359)

(cherry picked from commit 705eaec)

Co-authored-by: Pablo Galindo Salgado <[email protected]>
@C4ptainCrunch C4ptainCrunch mentioned this pull request Jun 1, 2022
Tracking of Python 3.11 compatibility ics-py/ics-py#337
Open
6 of 9 tasks
@hugovk hugovk mentioned this pull request Jun 1, 2022
None annotation for __init__ constructors/functions prettytable/prettytable#186
Merged
@davidhewitt davidhewitt mentioned this pull request Jun 1, 2022
ci: pin to 3.11.0-beta.1 PyO3/pyo3#2415
Merged
LeMyst added a commit to LeMyst/WikibaseIntegrator that referenced this pull request Jun 1, 2022
@LeMyst
Disable pytest on 3.11-dev
549008e 
Solved in python/cpython#93359
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arhadthedev arhadthedev arhadthedev left review comments
@isidentical isidentical Awaiting requested review from isidentical
@markshannon markshannon Awaiting requested review from markshannon

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash on AST with misordered linenos

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pablogsal @nedbat @miss-islington @bedevere-bot @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.