GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.11] gh-93345: Fix a crash in substitution of nested TypeVar after TypeVarTuple (GH-93346) by miss-islington · Pull Request #93402 · python/cpython

Conversation

miss-islington commented Jun 1, 2022

Copy link

Copy Markdown

Contributor

For example: tuple[*Ts, list[T]][int, str, bool]
(cherry picked from commit f545fc9)

Co-authored-by: Serhiy Storchaka [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-93345: Fix a crash in substitution of nested TypeVar after T…

ba4da2a

…ypeVarTuple (pythonGH-93346)

For example: tuple[*Ts, list[T]][int, str, bool]
(cherry picked from commit f545fc9)

Co-authored-by: Serhiy Storchaka <[email protected]>

miss-islington requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners

June 1, 2022 06:19

miss-islington commented Jun 1, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot mentioned this pull request

Jun 1, 2022

gh-93345: Fix a crash in substitution of nested TypeVar after TypeVarTuple #93346

Merged

miss-islington commented Jun 1, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added type-crash

A hard crash of the interpreter, possibly with a core dump

awaiting review labels

Jun 1, 2022

serhiy-storchaka approved these changes

Jun 1, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels

Jun 1, 2022

miss-islington commented Jun 1, 2022

Copy link

Copy Markdown

Contributor Author

Status check is done, and it's a success ✅ .

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington merged commit 3265ff9 into python:3.11

Jun 1, 2022

bedevere-bot removed the awaiting merge label

Jun 1, 2022

miss-islington deleted the backport-f545fc9-3.11 branch

June 1, 2022 06:43

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

gvanrossum

Awaiting requested review from gvanrossum

gvanrossum is a code owner

Fidget-Spinner

Awaiting requested review from Fidget-Spinner

JelleZijlstra

Awaiting requested review from JelleZijlstra

JelleZijlstra is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-crash

A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.