GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93345: Fix a crash in substitution of nested TypeVar after TypeVarTuple by serhiy-storchaka · Pull Request #93346 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 30, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closes #93345.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-93345: Fix a crash in substitution of nested TypeVar after T…
f8005fc 
…ypeVarTuple
@serhiy-storchaka serhiy-storchaka added type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes labels May 30, 2022
@bedevere-bot bedevere-bot added the awaiting core review label May 30, 2022
@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review May 30, 2022 07:25
@serhiy-storchaka
serhiy-storchaka requested review from Fidget-Spinner, JelleZijlstra and gvanrossum as code owners May 30, 2022 07:25
@serhiy-storchaka
Merge branch 'main' into typing-subst-nested-typevar-after-typevartuple
6b8e95a
Fidget-Spinner
Fidget-Spinner approved these changes May 30, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2022-05-30-10-22-46.gh-issue-93345.gi1A4L.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels May 30, 2022
@serhiy-storchaka @Fidget-Spinner
Update Misc/NEWS.d/next/Core and Builtins/2022-05-30-10-22-46.gh-issu…
936f4ac 
…e-93345.gi1A4L.rst

Co-authored-by: Ken Jin <[email protected]>
@serhiy-storchaka
serhiy-storchaka merged commit f545fc9 into python:main May 31, 2022
@miss-islington

miss-islington commented May 31, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label May 31, 2022
@serhiy-storchaka
serhiy-storchaka deleted the typing-subst-nested-typevar-after-typevartuple branch May 31, 2022 05:46
@miss-islington

miss-islington commented May 31, 2022

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f545fc955aeb701ae4e73b07ff2283f823d857b8 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka May 31, 2022
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jun 1, 2022
@miss-islington

miss-islington commented Jun 1, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2022
@serhiy-storchaka @miss-islington
pythongh-93345: Fix a crash in substitution of nested TypeVar after T…
ba4da2a 
…ypeVarTuple (pythonGH-93346)

For example: tuple[*Ts, list[T]][int, str, bool]
(cherry picked from commit f545fc9)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 1, 2022

Copy link
Copy Markdown

GH-93402 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 1, 2022
miss-islington added a commit that referenced this pull request Jun 1, 2022
@miss-islington @serhiy-storchaka
gh-93345: Fix a crash in substitution of nested TypeVar after TypeVar…
3265ff9 
…Tuple (GH-93346)

For example: tuple[*Ts, list[T]][int, str, bool]
(cherry picked from commit f545fc9)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crash in substitution of nested TypeVar after TypeVarTuple

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @miss-islington @bedevere-bot @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.