GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-93516: Backport GH-93769: Store offset of first traceable instruction in code object by markshannon · Pull Request #93818 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jun 14, 2022

Copy link
Copy Markdown
Member

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Jun 14, 2022
@markshannon
markshannon requested a review from pablogsal June 14, 2022 16:37
@markshannon

markshannon commented Jun 14, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

The ABI check fails, due to adding the _co_firsttraceable field.
I've added it near the end, so that code that accesses fields other that co_extra and co_code_adaptive will not be effected.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon markshannon mentioned this pull request Jun 14, 2022
Severe performance degradation for tracing under 3.11 #93516
Open
@nedbat

nedbat commented Jun 15, 2022

Copy link
Copy Markdown
Member

I tried this compared to 3.11.0b3, and this code is slightly slower?

cov proj python3.11 gh93818 93818 vs 3.11
6.4.1 bug1339.py 0.846 s 0.856 s 101.20%
6.4.1 bm_sudoku.py 55.436 s 57.561 s 103.83%
6.4.1 bm_spectral_norm.py 66.488 s 68.803 s 103.48%
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented Jun 15, 2022

Copy link
Copy Markdown
Member Author

Odd.
I wouldn't expect this to have much effect compared to removing the overhead of line number lookup, or caching the result of PyCode_GetCode(), but I would expect it to be positive.

Let's remeasure after those are merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon markshannon mentioned this pull request Jun 17, 2022
GH-93516: Speedup line number checks when tracing. #93763
Merged
@markshannon
pythonGH-93516: Speedup line number checks when tracing. (pythonGH-93763
0bd6735 
)

* Use a lookup table to reduce overhead of getting line numbers during tracing.
@markshannon
markshannon force-pushed the backport-93516 branch from aa8011d to 0bd6735 Compare June 20, 2022 13:29
@pablogsal

pablogsal commented Jun 21, 2022

Copy link
Copy Markdown
Member

I'm regenerating the ABI in this PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Jun 21, 2022

Copy link
Copy Markdown
Member

@markshannon I cannot push to the remote repo, could you please ensure the "allow pushes from maintainers checkbox is activated on the right column"?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon markshannon mentioned this pull request Jun 22, 2022
[3.11] GH-93516: Backport GH-93769: Speedup line number checks when tracing (GH-94127) #94127
Merged
@markshannon

markshannon commented Jun 22, 2022

Copy link
Copy Markdown
Member Author

Closing this until I've had time to investigate the slowdown once #94127 is merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon markshannon closed this Jun 22, 2022
@markshannon
markshannon deleted the backport-93516 branch September 26, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @nedbat @pablogsal @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.