GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-93516: Backport GH-93769: Speedup line number checks when tracing (GH-94127) by markshannon · Pull Request #94127 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jun 22, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Severe performance degradation for tracing under 3.11 #93516

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
pythonGH-93516: Speedup line number checks when tracing. (pythonGH-93763
0bd6735 
)

* Use a lookup table to reduce overhead of getting line numbers during tracing.
@bedevere-bot bedevere-bot added the awaiting core review label Jun 22, 2022
@markshannon markshannon changed the title [3.11] GH-93516: Backport GH-93769: Store offset of first traceable instruction in code object [3.11] GH-93516: Backport GH-93769: Speedup line number checks when tracing. Jun 22, 2022
This was referenced Jun 22, 2022
[3.11] GH-93516: Speedup line number checks when tracing. (GH-93763) #94023
Closed
[3.11] GH-93516: Backport GH-93769: Store offset of first traceable instruction in code object #93818
Closed
@pablogsal
Regenerate ABI dump file
77ec7f1
@pablogsal pablogsal added the 🤖 automerge label Jun 22, 2022
pablogsal
pablogsal approved these changes Jun 22, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 22, 2022
@pablogsal pablogsal changed the title [3.11] GH-93516: Backport GH-93769: Speedup line number checks when tracing. [3.11] GH-93516: Backport GH-93769: Speedup line number checks when tracing Jun 22, 2022
@pablogsal pablogsal added skip news skip issue and removed skip issue labels Jun 22, 2022
@pablogsal pablogsal changed the title [3.11] GH-93516: Backport GH-93769: Speedup line number checks when tracing [3.11]GH-93516: Backport GH-93769: Speedup line number checks when tracing Jun 22, 2022
@pablogsal pablogsal changed the title [3.11]GH-93516: Backport GH-93769: Speedup line number checks when tracing [3.11] GH-93516: Backport GH-93769: Speedup line number checks when tracing Jun 22, 2022
@miss-islington

miss-islington commented Jun 22, 2022

Copy link
Copy Markdown
Contributor

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal changed the title [3.11] GH-93516: Backport GH-93769: Speedup line number checks when tracing [3.11] GH-93516: Backport GH-93769: Speedup line number checks when tracing (GH-94127) Jun 22, 2022
@pablogsal
pablogsal merged commit 3ece6e6 into python:3.11 Jun 22, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @miss-islington @pablogsal @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.