GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94185: Fix PyObject_NEW and PyObject_NEW_VAR by trcrsired · Pull Request #94186 · python/cpython

Conversation

@trcrsired

@trcrsired trcrsired commented Jun 23, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

The commit 7ad6f74 tried to add brackets to tons of macros, but they break PyObject_New and PyObject_NEW_VAR since the macro would expand to ((Type)*) which breaks compilation for those CPython headers.

Fix the issue 94185.

  • Issue: PyObject_New breaks by the commit 7ad6f74fcf9db1ccfeaf0986064870d8d3887300 #94185

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
trcrsired added 2 commits June 23, 2022 14:39
@trcrsired
Fix PyObject_NEW and PyObject_NEW_VAR by removing their first bracket…
f1f5622 
… pair

The problem is that ((type) *) is not working. Randomly adding brackets to macros are not going to work
@trcrsired
Forget to commit the fix for PyObject_New_VAR
2f96e2e 
Fix them
@ghost

ghost commented Jun 23, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting review label Jun 23, 2022
@bedevere-bot

bedevere-bot commented Jun 23, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
trcrsired and others added 3 commits June 23, 2022 15:01
@trcrsired
Add NEWs for Fix PyObject_NEW and PyObject_NEW_VAR
7dc8d6d
@trcrsired
Merge branch 'main' into main
ff6d652
@trcrsired
Merge branch 'main' into main
85c8de6
@corona10
corona10 requested a review from vstinner June 24, 2022 15:53
@vstinner

vstinner commented Jun 24, 2022

Copy link
Copy Markdown
Member

This change lacks unit tests: I wrote PR #94234 which adds tests.

Thanks for the bug report and the PR!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303

kumaraditya303 commented Jun 26, 2022

Copy link
Copy Markdown
Contributor

Fixed by #94234
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 closed this Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@trcrsired @bedevere-bot @vstinner @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.