GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-87347: Fix PyObject_NEW() regression by vstinner · Pull Request #94234 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 24, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Don't add parenthesis around the type parameter.

Add unit tests on PyObject_NEW() and similar functions.

  • Issue: Python macros don’t shield arguments #87347

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner vstinner added the skip news label Jun 24, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jun 24, 2022
@vstinner
vstinner marked this pull request as ready for review June 24, 2022 16:49
@vstinner vstinner mentioned this pull request Jun 24, 2022
gh-94185: Fix PyObject_NEW and PyObject_NEW_VAR #94186
Closed
@vstinner

vstinner commented Jun 24, 2022

Copy link
Copy Markdown
Member Author

cc @corona10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jun 24, 2022
PyObject_New breaks by the commit 7ad6f74fcf9db1ccfeaf0986064870d8d3887300 #94185
Closed
corona10
corona10 approved these changes Jun 24, 2022
View reviewed changes

@corona10 corona10 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 24, 2022
erlend-aasland
erlend-aasland approved these changes Jun 24, 2022
View reviewed changes
kumaraditya303
kumaraditya303 reviewed Jun 24, 2022
View reviewed changes
Comment thread Modules/_testcapimodule.c Outdated

@kumaraditya303 kumaraditya303 Jun 24, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused macro?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@erlend-aasland erlend-aasland Jun 24, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like leftovers from an early revision. I'm sure Victor will remove it before merging.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@vstinner vstinner Jun 26, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I forgot about it. That's why reviews are great :-) I removed this unused macro. I used if+goto instead of the macro.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-87347: Fix PyObject_NEW() regression
72abb20 
Don't add parenthesis around the type parameter.

Add unit tests on PyObject_NEW() and similar functions.
kumaraditya303
kumaraditya303 approved these changes Jun 26, 2022
View reviewed changes
@vstinner
vstinner merged commit 44c8e68 into python:main Jun 26, 2022
@vstinner
vstinner deleted the object_new branch June 26, 2022 10:40
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 26, 2022
@vstinner

vstinner commented Jun 26, 2022

Copy link
Copy Markdown
Member Author

Merged, thanks for reviews!
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 27, 2022

Copy link
Copy Markdown
Member Author

Oops, my test leaks 4 references: I wrote PR #94330 to fix it.
erlend-aasland reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@corona10 corona10 corona10 approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vstinner @corona10 @erlend-aasland @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.