GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-93692: remove "build finished successfully" message from setup.py (GH-93693) by miss-islington · Pull Request #94209 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 24, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The message was only emitted when the build succeeded and there were
missing modules.
(cherry picked from commit ab077d1)

Co-authored-by: Erlend Egeberg Aasland [email protected]

  • Issue: setup.py only reports successful builds if one or more stdlib modules are missing #93692

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland @miss-islington
pythongh-93692: remove "build finished successfully" message from set…
17354a7 
…up.py (pythonGH-93693)

The message was only emitted when the build succeeded _and_ there were
missing modules.
(cherry picked from commit ab077d1)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot bedevere-bot added the awaiting review label Jun 24, 2022
@bedevere-bot bedevere-bot mentioned this pull request Jun 24, 2022
gh-93692: remove redundant "build finished successfully" message from setup.py #93693
Merged
@bedevere-bot bedevere-bot added the skip news label Jun 24, 2022
@miss-islington

miss-islington commented Jun 24, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
2 similar comments
@miss-islington

miss-islington commented Jun 24, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jun 24, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland
erlend-aasland approved these changes Jun 24, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jun 24, 2022
@miss-islington

miss-islington commented Jun 24, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: 3 of 6 required status checks are expected..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jun 24, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 92d32b9 into python:3.10 Jun 24, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 24, 2022
@miss-islington
miss-islington deleted the backport-ab077d1-3.10 branch June 24, 2022 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.