GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94216: add pseudo instructions to the dis/opcodes modules by iritkatriel · Pull Request #94241 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jun 24, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closes #94241.

  • Issue: Add virtual opcodes to the dis/opcodes modules #94216

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
iritkatriel added 2 commits June 23, 2022 22:54
@iritkatriel
remove unused (and undocumented) hasnargs
8bd5b3f
@iritkatriel
add virtual opcodes to the opcode and dis modules
3c99934
@iritkatriel
iritkatriel requested a review from markshannon as a code owner June 24, 2022 19:57
@bedevere-bot bedevere-bot added the awaiting core review label Jun 24, 2022
blurb-it Bot and others added 2 commits June 24, 2022 20:00
@blurb-it
📜🤖 Added by blurb_it.
14c5a1e
@iritkatriel
add to whatsnew
de6470a
@iritkatriel
iritkatriel requested review from brandtbucher and sweeneyde June 24, 2022 20:09
iritkatriel added 6 commits June 27, 2022 16:23
@iritkatriel
versionadded for new collections
16a5816
@iritkatriel
Merge remote-tracking branch 'upstream/main' into virtual_opcodes
66a3cb1
@iritkatriel
rename _HAVE_ARGUMENT back to HAVE_ARGUMENT
964b903
@iritkatriel
rename _HAVE_ARGUMENT back to HAVE_ARGUMENT (Lib/opcode.py)
9887e02
@iritkatriel
rename _HAVE_ARGUMENT back to HAVE_ARGUMENT (Tools/)
80d0828
@iritkatriel
rename _HAVE_ARGUMENT back to HAVE_ARGUMENT (regen-all)
986fd5d
gvanrossum
gvanrossum reviewed Jun 27, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, not a full review (Brandt or Mark can do that)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
applied Guido's comments
e91a8f5
@iritkatriel iritkatriel mentioned this pull request Jun 28, 2022
direct unit tests for compiler optimisations faster-cpython/ideas#405
Closed
markshannon
markshannon requested changes Jun 30, 2022
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should definitely help future testing.

Regarding "virtual opcode", I think I prefer the term pseudo-instruction, as used by RISC-V.
But that's for a future PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/dis.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 30, 2022
@bedevere-bot

bedevere-bot commented Jun 30, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Jun 30, 2022
iritkatriel added 2 commits June 30, 2022 12:17
@iritkatriel
fix error in SETUP_WITH documentation
1fa5255
@iritkatriel
remove mention of MAX_VIRTUAL_OPCODE from dis doc
0104267
@iritkatriel iritkatriel changed the title gh-94216: add virtual opcodes to the dis/opcodes modules gh-94216: add pseudo instructions to the dis/opcodes modules Jun 30, 2022
iritkatriel and others added 2 commits June 30, 2022 17:52
@iritkatriel
virtual --> pseudo
0cd9b73
@iritkatriel
Merge branch 'main' into virtual_opcodes
19024fa
@iritkatriel

iritkatriel commented Jun 30, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Jun 30, 2022
@bedevere-bot

bedevere-bot commented Jun 30, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from markshannon June 30, 2022 18:57
markshannon
markshannon requested changes Jul 1, 2022
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/dis.rst Outdated

.. opcode:: SETUP_WITH (target)

Like ``SETUP_FINALLY``, but in case of exception one more item is popped

@markshannon markshannon Jul 1, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be SETUP_CLEANUP.
Or leave it as SETUP_FINALLY and add the part about lasti.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@iritkatriel iritkatriel Jul 1, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting change review labels Jul 1, 2022
@bedevere-bot

bedevere-bot commented Jul 1, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
fix two errors in SETUP_WITH documentation
709755c
@iritkatriel

iritkatriel commented Jul 1, 2022

Copy link
Copy Markdown
Member Author

I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting change review and removed awaiting changes labels Jul 1, 2022
@bedevere-bot

bedevere-bot commented Jul 1, 2022

Copy link
Copy Markdown

Thanks for making the requested changes!

@markshannon: please review the changes made to this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot
bedevere-bot requested a review from markshannon July 1, 2022 13:37
markshannon
markshannon approved these changes Jul 1, 2022
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting change review labels Jul 1, 2022
@iritkatriel
iritkatriel merged commit c57aad7 into python:main Jul 1, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 1, 2022
@iritkatriel
iritkatriel deleted the virtual_opcodes branch September 29, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum left review comments
@markshannon markshannon markshannon approved these changes
@sweeneyde sweeneyde Awaiting requested review from sweeneyde
@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@iritkatriel @bedevere-bot @gvanrossum @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.