GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-90016: Deprecate default sqlite3 adapters and converters by erlend-aasland · Pull Request #94276 · python/cpython

Conversation

erlend-aasland commented Jun 25, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Closes gh-90016

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-90016: Deprecate default sqlite3 adapters and converters

2a586c4

erlend-aasland requested a review from berkerpeksag as a code owner

June 25, 2022 21:48

bedevere-bot added the awaiting core review label

Jun 25, 2022

erlend-aasland mentioned this pull request

Jun 25, 2022

Deprecate default converters in sqlite3 #90016

Closed

erlend-aasland commented Jun 25, 2022

Copy link

Copy Markdown

Contributor Author

cc. @iafisher: would you mind reviewing this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland requested review from AlexWaygood and CAM-Gerlach

June 25, 2022 21:57

iafisher reviewed

Jun 25, 2022

View reviewed changes

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/sqlite3/dbapi2.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Address first part of Ian's review

2ba83f6

erlend-aasland commented

Jun 26, 2022

View reviewed changes

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend Egeberg Aasland and others added 2 commits

June 27, 2022 18:00


          Update Doc/library/sqlite3.rst

fb18ab6


          Wordings

27eaa23

CAM-Gerlach reviewed

Jun 29, 2022

View reviewed changes

CAM-Gerlach left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erlend-aasland , and sorry for the delay! Just a handful of textual and reST/Sphinx fixes/suggestions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

There was an error while loading. Please reload this page.

AlexWaygood reviewed

Jul 1, 2022

View reviewed changes

AlexWaygood left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, +1 to most of Cam's thoughts

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Address review

d3dd3b4

erlend-aasland commented Jul 1, 2022

Copy link

Copy Markdown

Contributor Author

Reviews addressed in d3dd3b4

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach approved these changes

Jul 2, 2022

View reviewed changes

CAM-Gerlach left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland ! Just two minor fixes, both my mistake.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Comment thread

Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB409s.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Erlend Egeberg Aasland and others added 2 commits

July 2, 2022 08:34


          Update Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB…

df4dc31

…409s.rst

Co-authored-by: CAM Gerlach <[email protected]>


          Update Doc/whatsnew/3.12.rst

ffdf631

Co-authored-by: CAM Gerlach <[email protected]>

erlend-aasland requested review from malemburg and serhiy-storchaka

July 3, 2022 21:31

erlend-aasland commented Jul 3, 2022

Copy link

Copy Markdown

Contributor Author

@felixxm, I guess this change is ok with Django; AFAIK, you use your own adapters/converters?

@serhiy-storchaka and @malemburg, would you two mind reviewing this?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

felixxm commented Jul 4, 2022

Copy link

Copy Markdown

Contributor

@felixxm, I guess this change is ok with Django; AFAIK, you use your own adapters/converters?

Yes, it works for us 👍 Thanks for letting me know 🎁 . I prepared PR with missing adapters/converters for Django, see django/django#15815.

erlend-aasland reacted with hooray emoji

All reactions

🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

felixxm approved these changes

Jul 4, 2022

View reviewed changes

felixxm left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland Thanks 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Lib/sqlite3/dbapi2.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Address Mariusz' review

6213c3b

erlend-aasland commented Jul 20, 2022

Copy link

Copy Markdown

Contributor Author

I'll resolve the conflicts and land this PR later tonight.

CAM-Gerlach reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' into sqlite-deprecate-adapters

07988dc

erlend-aasland merged commit 6dadf6c into python:main

Jul 20, 2022

bedevere-bot removed the awaiting core review label

Jul 20, 2022

erlend-aasland deleted the sqlite-deprecate-adapters branch

July 20, 2022 19:38

hugovk mentioned this pull request

Nov 3, 2024

Docs: Delist default sqlite3 adapters and convertors deprecation from "Pending removal in 3.14" #126370

Merged

Reviewers

AlexWaygood

AlexWaygood left review comments

CAM-Gerlach

CAM-Gerlach approved these changes

berkerpeksag

Awaiting requested review from berkerpeksag

serhiy-storchaka

Awaiting requested review from serhiy-storchaka

malemburg

Awaiting requested review from malemburg

+2 more reviewers

iafisher

iafisher left review comments

felixxm

felixxm approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Deprecate default converters in sqlite3

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Jun 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commented Jun 25, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AlexWaygood left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Jul 1, 2022

Uh oh!

CAM-Gerlach left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Jul 3, 2022

Uh oh!

felixxm commented Jul 4, 2022

Uh oh!

felixxm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

erlend-aasland commented Jul 20, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

erlend-aasland commented Jun 25, 2022 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach left a comment •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.