GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Docs: Delist default sqlite3 adapters and convertors deprecation from "Pending removal in 3.14" by hugovk · Pull Request #126370 · python/cpython

Conversation

@hugovk

@hugovk hugovk commented Nov 3, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This was deprecated in 3.12 (#94276) but never planned to be removed in 3.14. It was added to the "Pending removal in Python 3.14" list by mistake, probably assuming it would be removed in +2 releases.

https://docs.python.org/3.13/library/sqlite3.html#default-adapters-and-converters-deprecated is correct: only says deprecated in 3.12.

See also https://discuss.python.org/t/deprecate-default-built-in-sqlite3-converters-and-adapters/15781.

📚 Documentation preview 📚: https://cpython-previews--126370.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Docs: remove sqlite3 deprecation with no pending removal date
551ba7e
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting core review labels Nov 3, 2024
@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes skip issue docs Documentation in the Doc dir awaiting core review skip news and removed docs Documentation in the Doc dir awaiting core review skip news labels Nov 3, 2024
@hugovk hugovk changed the title Docs: remove sqlite3 deprecation with no pending removal date Docs: Delist sqlite3 deprecation from "Pending removal in 3.14" Nov 3, 2024
@hugovk hugovk added the topic-sqlite3 label Nov 3, 2024
erlend-aasland
erlend-aasland approved these changes Nov 3, 2024
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Nov 3, 2024
@hugovk
hugovk enabled auto-merge (squash) November 3, 2024 21:15
@hugovk
hugovk merged commit 9441993 into python:main Nov 3, 2024
@hugovk
hugovk deleted the rm-sqlite3-pending branch November 3, 2024 21:22
@miss-islington-app

miss-islington-app Bot commented Nov 3, 2024

Copy link
Copy Markdown

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Nov 3, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2024
@hugovk @miss-islington
Docs: Delist sqlite3 deprecation from "Pending removal in 3.14" (pyth…
0e57ee0 
…onGH-126370)

(cherry picked from commit 9441993)

Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2024
@hugovk @miss-islington
Docs: Delist sqlite3 deprecation from "Pending removal in 3.14" (pyth…
aafbaaf 
…onGH-126370)

(cherry picked from commit 9441993)

Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Nov 3, 2024

Copy link
Copy Markdown

GH-126372 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Nov 3, 2024
@bedevere-app

bedevere-app Bot commented Nov 3, 2024

Copy link
Copy Markdown

GH-126373 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Nov 3, 2024
hugovk added a commit that referenced this pull request Nov 3, 2024
@miss-islington @hugovk
[3.13] Docs: Delist sqlite3 deprecation from "Pending removal in 3.14" (
c095598 
GH-126370) (#126372)

Co-authored-by: Hugo van Kemenade <[email protected]>
hugovk added a commit that referenced this pull request Nov 3, 2024
@miss-islington @hugovk
[3.12] Docs: Delist sqlite3 deprecation from "Pending removal in 3.14" (
37dc2b2 
GH-126370) (#126373)

Co-authored-by: Hugo van Kemenade <[email protected]>
@Wulian233

Wulian233 commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

Should we add it to pending remove in future.rst?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Nov 4, 2024

Copy link
Copy Markdown
Contributor

Should we add it to pending remove in future.rst?

No; it is not pending removal at all.
gpshead reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead gpshead changed the title Docs: Delist sqlite3 deprecation from "Pending removal in 3.14" Docs: Delist default sqlite3 adapters and convertors deprecation from "Pending removal in 3.14" Nov 10, 2024
picnixz pushed a commit to picnixz/cpython that referenced this pull request Dec 8, 2024
@hugovk @picnixz
Docs: Delist sqlite3 deprecation from "Pending removal in 3.14" (pyth…
69b0911 
…on#126370)
ebonnal pushed a commit to ebonnal/cpython that referenced this pull request Jan 12, 2025
@hugovk @ebonnal
Docs: Delist sqlite3 deprecation from "Pending removal in 3.14" (pyth…
342bb2e 
…on#126370)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news topic-sqlite3

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@hugovk @Wulian233 @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.