GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94172: Remove ssl.PROTOCOL_SSLv2 dead code by vstinner · Pull Request #94312 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Jun 26, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Remove dead code related to ssl.PROTOCOL_SSLv2. ssl.PROTOCOL_SSLv2
was already removed in Python 3.10.

In test_ssl, @requires_tls_version('SSLv2') always returned False.

Extract of the removed code: "OpenSSL has removed support for SSLv2".

  • Issue: Remove deprecated keyfile, certfile and check_hostname parameters, in favor of context #94172

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-94172: Remove ssl.PROTOCOL_SSLv2 dead code
204e41e 
Remove dead code related to ssl.PROTOCOL_SSLv2. ssl.PROTOCOL_SSLv2
was already removed in Python 3.10.

In test_ssl, @requires_tls_version('SSLv2') always returned False.

Extract of the removed code: "OpenSSL has removed support for SSLv2".
@bedevere-bot bedevere-bot added the awaiting core review label Jun 26, 2022
@vstinner
vstinner marked this pull request as ready for review June 26, 2022 23:37
@vstinner vstinner mentioned this pull request Jun 26, 2022
gh-94172: Remove keyfile, certfile and check_hostname parameters #94173
Merged
@vstinner vstinner added the skip news label Jun 26, 2022
@vstinner

vstinner commented Jun 26, 2022

Copy link
Copy Markdown
Member Author

vstinner added the skip news label now

The only effect for end users is the removal of the documentation. The ssl.PROTOCOL_SSLv2 constant was already removed in Python 3.10.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 26, 2022

Copy link
Copy Markdown
Member Author

On Fedora 36, OPENSSL_NO_SSL3 is defined by /usr/include/openssl/configuration-x86_64.h. This file is documented as:

OpenSSL was configured with the following options

It seems like disabling SSLv3 is still a configuration option in OpenSSL 3.0.3.

For me, it's not obvious that Python no longer supports SSLv3. It seems to depend if SSLv3 was disabled in OpenSSL configuration (when OpenSSL was built).

Python ssl.SSLContext() sets SSL_OP_NO_SSLv3 option, unless protocol=PY_SSL_VERSION_SSL3.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Jun 26, 2022

Copy link
Copy Markdown
Member Author

cc @tiran
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 600c65c into python:main Jun 28, 2022
@vstinner
vstinner deleted the ssl_v2 branch June 28, 2022 11:57
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 28, 2022
@vstinner

vstinner commented Jun 28, 2022

Copy link
Copy Markdown
Member Author

Follow-up: issue #94377 "ssl: Drop support for unsafe SSLv3 protocol, remove ssl.PROTOCOL_SSLv3".
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Jun 28, 2022
ssl: Drop support for unsafe SSLv3 protocol, remove ssl.PROTOCOL_SSLv3 #94377
Closed
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 30, 2022
@vstinner @gvanrossum
pythongh-94172: Remove ssl.PROTOCOL_SSLv2 dead code (python#94312)
8e1bce0 
Remove dead code related to ssl.PROTOCOL_SSLv2. ssl.PROTOCOL_SSLv2
was already removed in Python 3.10.

In test_ssl, @requires_tls_version('SSLv2') always returned False.

Extract of the removed code: "OpenSSL has removed support for SSLv2".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.