GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||
GeezerVison is showing github.com — gh-94017: Improve clarity of sqlite3 transaction handling docs by erlend-aasland · Pull Request #94320 · python/cpython Conversation
|
|
cc. @CAM-Gerlach, @AlexWaygood. Would you two mind reviewing this? I'll go over it later today, to be sure the docs align with the actual implementation. Other that, I worry that the new tone of the docs may come across as ... perhaps a trifle strict, or negative sounding (in lack of more appropriate words). I also worry about the added verbosity. I do hope this makes things clearer, though. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…ite-doc-tx-handling
… the underlying library
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks @erlend-aasland , this is a definite improvement. I do have some clarity, textual and reST fixes and suggestions.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
+1 to most of Cam's thoughts
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Thanks, both of you; highly appreciated. I'm finally getting around to address the reviews. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Reviews addressed in a530b3e. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
That's fine with me, since it isn't used on multiple classes in the module and links directly to them in either case. I wasn't very consistent about using that myself. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @erlend-aasland
I had one comment, but that might be out of scope here and better addressed in a future PR.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I'm sorry, but I did a last rewrite of things, trying to address #94320 (comment). Hopefully to the better. I'd be happy if you could review commit 1473e94. If it was for the worse, I'll revert it. For the "Controlling Transactions" section, I tried to improve the visual separation of the two sqlite3 transaction modes. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <[email protected]>
No need to apologize for doing more work and making the docs better! I'll review it now—sorry myself for the delay; it was a holiday weekend and I was with family. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Review feedback on the final revisisions
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: CAM Gerlach <[email protected]>
|
Thanks again for the reviews; I'll land this later tonight. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ythonGH-94320) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: CAM Gerlach <[email protected]> (cherry picked from commit 760b8cf) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
|
GH-94617 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ythonGH-94320) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: CAM Gerlach <[email protected]> (cherry picked from commit 760b8cf) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
|
GH-94618 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: CAM Gerlach <[email protected]> (cherry picked from commit 760b8cf) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
) Co-authored-by: Alex Waygood <[email protected]> Co-authored-by: CAM Gerlach <[email protected]> (cherry picked from commit 760b8cf) Co-authored-by: Erlend Egeberg Aasland <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
Improve clarity of sqlite3 transaction handling docs
There was an error while loading. Please reload this page.