GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94404: Use module CFLAGS before PY_STDMODULE_CFLAGS by tiran · Pull Request #94413 · python/cpython

Conversation

@tiran

@tiran tiran commented Jun 29, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PY_STDMODULE_CFLAGS may contain include directories with system
headers. This can break compiling with built-in libmpdec.

  • Issue: makesetup can fail on macOS and uses wrong CFLAGS #94404

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
pythongh-94404: Use module CFLAGS before PY_STDMODULE_CFLAGS
78cb92f 
``PY_STDMODULE_CFLAGS`` may contain include directories with system
headers. This can break compiling with built-in libmpdec.
@tiran tiran added the needs backport to 3.11 only security fixes label Jun 29, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jun 29, 2022
@tiran
tiran merged commit 6485c3c into python:main Jun 29, 2022
@miss-islington

miss-islington commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 29, 2022
@miss-islington

miss-islington commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

Sorry @tiran, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 6485c3c7267eeb4095530af474c43f1244cb492b 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran deleted the gh-94404-order branch June 29, 2022 13:44
@miss-islington miss-islington assigned tiran Jun 29, 2022
tiran added a commit to tiran/cpython that referenced this pull request Jun 29, 2022
@tiran
[3.11] pythongh-94404: Use module CFLAGS before PY_STDMODULE_CFLAGS (p…
22491a6 
…ythonGH-94413)

``PY_STDMODULE_CFLAGS`` may contain include directories with system
headers. This can break compiling with built-in libmpdec.
(cherry picked from commit 6485c3c)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 29, 2022

Copy link
Copy Markdown

GH-94415 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 29, 2022
tiran added a commit that referenced this pull request Jun 29, 2022
@tiran
[3.11] gh-94404: Use module CFLAGS before PY_STDMODULE_CFLAGS (GH-94413…
a548a45 
…) (GH-94415)

``PY_STDMODULE_CFLAGS`` may contain include directories with system
headers. This can break compiling with built-in libmpdec.
Co-authored-by: Christian Heimes <[email protected]>
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 30, 2022
@tiran @gvanrossum
pythongh-94404: Use module CFLAGS before PY_STDMODULE_CFLAGS (pythonG…
6e77150 
…H-94413)

``PY_STDMODULE_CFLAGS`` may contain include directories with system
headers. This can break compiling with built-in libmpdec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@tiran tiran

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tiran @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.