GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93491: Fix PEP 11 tier detection for FreeBSD (GH-94441) by tiran · Pull Request #94441 · python/cpython

Conversation

@tiran

@tiran tiran commented Jun 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

FreeBSD triple includes release, e.g. x86_64-unknown-freebsd14.0.

  • Issue: Check and report PEP 11 support tier in configure #93491

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
pythongh-93491: Fix PEP 11 tier detection for FreeBSD
f9e9505 
FreeBSD triple includes release, e.g. ``x86_64-unknown-freebsd14.0``.
@tiran tiran added skip news needs backport to 3.11 only security fixes labels Jun 30, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jun 30, 2022
@tiran
tiran requested a review from vstinner June 30, 2022 13:59
@tiran tiran added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 30, 2022
@bedevere-bot

bedevere-bot commented Jun 30, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @tiran for commit f9e9505 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 30, 2022
vstinner
vstinner approved these changes Jun 30, 2022
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 30, 2022
@tiran tiran changed the title gh-93491: Fix PEP 11 tier detection for FreeBSD gh-93491: Fix PEP 11 tier detection for FreeBSD (GH-94441) Jun 30, 2022
@tiran
tiran merged commit 67d208f into python:main Jun 30, 2022
@tiran
tiran deleted the gh-93491-freebsd branch June 30, 2022 16:04
@miss-islington

miss-islington commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 30, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 30, 2022
@tiran @miss-islington
pythongh-93491: Fix PEP 11 tier detection for FreeBSD (pythonGH-94441)
2698fee 
(cherry picked from commit 67d208f)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 30, 2022
@bedevere-bot

bedevere-bot commented Jun 30, 2022

Copy link
Copy Markdown

GH-94455 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Jun 30, 2022
@miss-islington @tiran
gh-93491: Fix PEP 11 tier detection for FreeBSD (GH-94441)
8ee4e12 
(cherry picked from commit 67d208f)

Co-authored-by: Christian Heimes <[email protected]>
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Jun 30, 2022
@tiran @gvanrossum
pythongh-93491: Fix PEP 11 tier detection for FreeBSD (pythonGH-94441)
9eb94f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @bedevere-bot @miss-islington @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.