GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-94438: Account for NULLs on evaluation stack when jumping lines. by markshannon · Pull Request #94444 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Jun 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: frame.setlineno has serious flaws. #94438

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Account for NULLs on evaluation stack when jumping lines.
578940b
@markshannon
markshannon requested a review from iritkatriel June 30, 2022 14:19
@bedevere-bot bedevere-bot added the awaiting core review label Jun 30, 2022
@markshannon markshannon added the needs backport to 3.11 only security fixes label Jun 30, 2022
Fidget-Spinner
Fidget-Spinner reviewed Jun 30, 2022
View reviewed changes
Comment thread Objects/frameobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel
iritkatriel reviewed Jul 1, 2022
View reviewed changes
Comment thread Lib/test/test_sys_settrace.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
markshannon added 2 commits July 1, 2022 10:11
@markshannon
Handle LOAD_ATTR in frame.setlineno stack analysis.
5876efe
@markshannon
Add tests for LOAD_ATTR and PUSH_NULL.
4dfe07c
iritkatriel
iritkatriel approved these changes Jul 1, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 1, 2022
@markshannon markshannon closed this Jul 1, 2022
@markshannon markshannon reopened this Jul 1, 2022
@markshannon
Merge branch 'main' into more-robust-frame-setlineno
e1c98ab
@markshannon
markshannon merged commit be80db1 into python:main Jul 1, 2022
@miss-islington

miss-islington commented Jul 1, 2022

Copy link
Copy Markdown
Contributor

Thanks @markshannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed awaiting merge needs backport to 3.11 only security fixes labels Jul 1, 2022
@bedevere-bot

bedevere-bot commented Jul 1, 2022

Copy link
Copy Markdown

GH-94484 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 1, 2022
@markshannon @miss-islington
pythonGH-94438: Account for NULLs on evaluation stack when jumping li…
edfdd6e 
…nes. (pythonGH-94444)

(cherry picked from commit be80db1)

Co-authored-by: Mark Shannon <[email protected]>
markshannon added a commit that referenced this pull request Jul 1, 2022
@markshannon
[3.11] GH-94438: Backport GH-94444 (#94486)
02b30a8 
* Account for NULLs on evaluation stack when jumping lines.
@markshannon
markshannon deleted the more-robust-frame-setlineno branch September 26, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner left review comments
@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@markshannon @miss-islington @bedevere-bot @iritkatriel @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.