GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-84753: Clarify change made to `inspect` functions by ambv · Pull Request #94554 · python/cpython

Conversation

@ambv

@ambv ambv commented Jul 5, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The wording used in GH-94050 suggests narrower scope than what was actually implemented. This commit clarifies the full impact of GH-94050 in the change log.

New wording:
Screen Shot 2022-07-05 at 11 03 02

  • Issue: inspect.iscorutinefunction() returns False for unittest.mock.AsyncMock instances #84753

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ambv
pythongh-84753: Clarify change made to inspect functions
18695d7 
The wording used in pythonGH-94050 suggests narrower scope than what was actually
implemented. This commit clarifies the full impact of pythonGH-94050 in the change
log.
@ambv ambv added needs backport to 3.10 needs backport to 3.11 only security fixes labels Jul 5, 2022
@ambv ambv assigned pablogsal Jul 5, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jul 5, 2022
pablogsal
pablogsal approved these changes Jul 5, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 5, 2022
kumaraditya303
kumaraditya303 approved these changes Jul 5, 2022
View reviewed changes
@pablogsal
pablogsal merged commit a2a3f2c into python:main Jul 5, 2022
@miss-islington

miss-islington commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @ambv for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 5, 2022
@miss-islington

miss-islington commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

Sorry @ambv and @pablogsal, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker a2a3f2c541290fc8f0720d1abdc12d564b856c28 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 5, 2022

Copy link
Copy Markdown

GH-94559 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jul 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2022
@ambv @miss-islington
pythongh-84753: Clarify change made to inspect functions (pythonGH-…
d1deb60 
…94554)

(cherry picked from commit a2a3f2c)

Co-authored-by: Łukasz Langa <[email protected]>
@ambv
ambv deleted the gh-84753 branch July 5, 2022 12:23
@ambv ambv removed the needs backport to 3.11 only security fixes label Jul 5, 2022
ambv added a commit that referenced this pull request Jul 5, 2022
@miss-islington @ambv
gh-84753: Clarify change made to inspect functions (GH-94554) (GH-9…
3472f3b 
…4559)

(cherry picked from commit a2a3f2c)

Co-authored-by: Łukasz Langa <[email protected]>
@ambv ambv added the needs backport to 3.11 only security fixes label Jul 5, 2022
@miss-islington

miss-islington commented Jul 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @ambv for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 5, 2022

Copy link
Copy Markdown

GH-94560 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 5, 2022
@ambv @miss-islington
pythongh-84753: Clarify change made to inspect functions (pythonGH-…
44160bd 
…94554)

(cherry picked from commit a2a3f2c)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this pull request Jul 5, 2022
@miss-islington @ambv
gh-84753: Clarify change made to inspect functions (GH-94554) (GH-9…
0615e7f 
…4560)

(cherry picked from commit a2a3f2c)

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@ambv @miss-islington @bedevere-bot @pablogsal @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.