GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94438: in frameobject's mark_stacks switch, the PUSH_EXC_INFO and POP_EXCEPT cases are no longer reachable by iritkatriel · Pull Request #94582 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Jul 5, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: frame.setlineno has serious flaws. #94438

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-94438: in frameobject's mark_stacks switch, the PUSH_EXC_INF…
9efd9e0 
…O and POP_EXCEPT cases are no longer reachable
@iritkatriel
iritkatriel requested a review from markshannon as a code owner July 5, 2022 18:52
@bedevere-bot bedevere-bot added the awaiting core review label Jul 5, 2022
@iritkatriel iritkatriel mentioned this pull request Jul 5, 2022
frame.setlineno has serious flaws. #94438
Closed
3 tasks done
mdboom
mdboom reviewed Jul 5, 2022
View reviewed changes
Comment thread Objects/frameobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
add break and more info in the comment
46a4a9b
@iritkatriel
iritkatriel requested a review from pablogsal July 5, 2022 19:14
@sweeneyde

sweeneyde commented Jul 5, 2022

Copy link
Copy Markdown
Member

Maybe this is already understood, but stacks remaining UNINITIALIZED seems to be the cause of #92228
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran
tiran approved these changes Jul 5, 2022
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 5, 2022
pablogsal
pablogsal approved these changes Jul 5, 2022
View reviewed changes
@pablogsal pablogsal added skip news needs backport to 3.11 only security fixes labels Jul 5, 2022
@iritkatriel

iritkatriel commented Jul 5, 2022

Copy link
Copy Markdown
Member Author

Maybe this is already understood, but stacks remaining UNINITIALIZED seems to be the cause of #92228

I wasn't aware of this, I'll have a look thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel
iritkatriel merged commit 50b9a77 into python:main Jul 6, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 6, 2022
@miss-islington

miss-islington commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

Sorry @iritkatriel, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 50b9a7762f06335277d9962edc8d39498601a4e4 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned iritkatriel Jul 6, 2022
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Jul 6, 2022
iritkatriel added a commit to iritkatriel/cpython that referenced this pull request Jul 6, 2022
@iritkatriel
[3.11] pythongh-94438: in frameobject's mark_stacks switch, the PUSH_…
f2df71b 
…EXC_INFO and POP_EXCEPT cases are no longer reachable (pythonGH-94582)

(cherry picked from commit 50b9a77)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 6, 2022
@bedevere-bot

bedevere-bot commented Jul 6, 2022

Copy link
Copy Markdown

GH-94595 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
iritkatriel added a commit that referenced this pull request Jul 6, 2022
@iritkatriel
[3.11] gh-94438: in frameobject's mark_stacks switch, the PUSH_EXC_IN…
b22f9d6 
…FO and POP_EXCEPT cases are no longer reachable (GH-94582) (GH-94595)

(cherry picked from commit 50b9a77)

Co-authored-by: Irit Katriel <[email protected]>
@iritkatriel
iritkatriel deleted the setlineno branch September 29, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdboom mdboom mdboom left review comments
@pablogsal pablogsal pablogsal approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
+1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iritkatriel iritkatriel

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@iritkatriel @sweeneyde @miss-islington @bedevere-bot @mdboom @tiran @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.