GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-93896: Always set event loop in asyncio.run and IsolatedAsyncioTestCase (GH-94593) by miss-islington · Pull Request #94608 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 6, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 14fea6b)

Co-authored-by: Kumar Aditya [email protected]

  • Issue: IsolatedAsyncioTestCase and asyncio.run no-longer call asyncio.set_event_loop #93896

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303 @miss-islington
pythonGH-93896: AAlways set event loop in asyncio.run and IsolatedAsy…
d347aa7 
…ncioTestCase (pythonGH-94593)

(cherry picked from commit 14fea6b)

Co-authored-by: Kumar Aditya <[email protected]>
@miss-islington
miss-islington requested review from 1st1 and asvetlov as code owners July 6, 2022 15:18
@miss-islington

miss-islington commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Jul 6, 2022
GH-93896: always set event loop in asyncio.run and IsolatedAsyncioTestCase #94593
Merged
@bedevere-bot bedevere-bot added the awaiting review label Jul 6, 2022
@miss-islington

miss-islington commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Jul 6, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 6, 2022
@miss-islington

miss-islington commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: 6 of 9 required status checks are expected..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 approved these changes Jul 6, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
asvetlov
asvetlov approved these changes Jul 6, 2022
View reviewed changes
@kumaraditya303

kumaraditya303 commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

The title has a typo, would be nice to fix it. (I cannot edit).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal pablogsal changed the title [3.11] GH-93896: AAlways set event loop in asyncio.run and IsolatedAsyncioTestCase (GH-94593) [3.11] GH-93896: Always set event loop in asyncio.run and IsolatedAsyncioTestCase (GH-94593) Jul 6, 2022
@pablogsal

pablogsal commented Jul 6, 2022

Copy link
Copy Markdown
Member

Done 👍
kumaraditya303 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 6, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit 0187b60 into python:3.11 Jul 6, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 6, 2022
@miss-islington
miss-islington deleted the backport-14fea6b-3.11 branch July 6, 2022 15:48
@kumaraditya303 kumaraditya303 mentioned this pull request Jul 6, 2022
IsolatedAsyncioTestCase and asyncio.run no-longer call asyncio.set_event_loop #93896
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes
@pablogsal pablogsal pablogsal approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @kumaraditya303 @pablogsal @asvetlov @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.