GeezerVison is showing github.com — GH-93896: always set event loop in asyncio.run and IsolatedAsyncioTestCase by kumaraditya303 · Pull Request #94593 · python/cpython
Conversation
kumaraditya303
commented
Jul 6, 2022
•
edited by bedevere-bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
Can you copy over the test cases from my PR?
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Can you copy over the test cases from my PR?
I added a test.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix!
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
kumaraditya303 and ericsnowcurrently reacted with heart emoji
LGTM, thanks for the fix!
Thanks for the reviews!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
graingert
commented
Jul 6, 2022
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
I think the docs should describe this change:
class Runner:
"""A context manager that controls event loop life cycle.
The context manager always creates a new event loop,
allows to run async functions inside it, sets the policy loop,
and properly finalizes the loop at the context manager exit.
If debug is True, the event loop will be run in debug mode.
If loop_factory is passed, it is used for new event loop creation, however the
policy loop will not be set
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
I think the docs should describe this change:
class Runner:
"""A context manager that controls event loop life cycle.
The context manager always creates a new event loop,
allows to run async functions inside it, sets the policy loop,
and properly finalizes the loop at the context manager exit.
If debug is True, the event loop will be run in debug mode.
If loop_factory is passed, it is used for new event loop creation, however the
policy loop will not be set
This would complicate things for an average user about how policy registry works. The existing docs is clear If loop_factory is passed, it is used for new event loop creation. We can iterate over docs afterwards but let's fix the release blockers first.
|
asvetlov and graingert reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Thanks @kumaraditya303 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|