GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-94321: Document sqlite3.PrepareProtocol by erlend-aasland · Pull Request #94620 · python/cpython

Conversation

erlend-aasland commented Jul 6, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: Document sqlite3.PrepareProtocol #94321

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-94321: Document sqlite3.PrepareProtocol

7ad6f24

erlend-aasland requested a review from berkerpeksag as a code owner

July 6, 2022 21:32

bedevere-bot added the awaiting core review label

Jul 6, 2022

erlend-aasland linked an issue

Jul 6, 2022

that may be closed by this pull request

Document sqlite3.PrepareProtocol #94321

Closed

erlend-aasland requested a review from CAM-Gerlach

July 6, 2022 21:34

erlend-aasland added needs backport to 3.10 needs backport to 3.11

only security fixes

skip news docs Documentation in the Doc dir labels

Jul 6, 2022

erlend-aasland added 2 commits

July 6, 2022 23:38


          Adjust class docstr

d5b6ee8


          Fix syntax

a594f27

CAM-Gerlach requested changes

Jul 7, 2022

View reviewed changes

CAM-Gerlach left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth adding a NEWS entry?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Modules/_sqlite/prepare_protocol.c Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/sqlite3.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland removed the skip news label

Jul 7, 2022

erlend-aasland commented Jul 7, 2022

Copy link

Copy Markdown

Contributor Author

Maybe worth adding a NEWS entry?

Yeah, I thought about that myself.

CAM-Gerlach reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland added skip news and removed skip news labels

Jul 7, 2022


          Address CAM's review

e20fd19

erlend-aasland requested a review from CAM-Gerlach

July 7, 2022 06:44

erlend-aasland commented Jul 7, 2022

Copy link

Copy Markdown

Contributor Author

FYI, I'm merging this later tonight.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland mentioned this pull request

Jul 7, 2022

Doc: remove redundant refs in sqlite3 docs #94667

Closed

CAM-Gerlach reviewed

Jul 7, 2022

View reviewed changes

CAM-Gerlach left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a little confused—is sqlite3.PrepareProtocol a type of "Blob Object"? I assumed it wasn't, which motivated my suggested change to add its own section heading, since its currently under the "Blob Object" section. Just to confirm—I was mistaken about that?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with laugh emoji

All reactions

😄 1 reaction

erlend-aasland commented Jul 7, 2022

Copy link

Copy Markdown

Contributor Author

Aaaaah, I missed adding the header. Sorry!

CAM-Gerlach reacted with laugh emoji

All reactions

😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Add missing heading

cc04744

CAM-Gerlach approved these changes

Jul 7, 2022

View reviewed changes

CAM-Gerlach left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @erlend-aasland !

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with hooray emoji

All reactions

🎉 1 reaction

erlend-aasland merged commit fb6dcca into python:main

Jul 7, 2022

miss-islington commented Jul 7, 2022

Copy link

Copy Markdown

Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting core review label

Jul 7, 2022

erlend-aasland deleted the sqlite-doc-prepareprotocol branch

July 7, 2022 22:33

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 7, 2022


          pythongh-94321: Document sqlite3.PrepareProtocol (pythonGH-94620)

41166c7

(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

miss-islington commented Jul 7, 2022

Copy link

Copy Markdown

Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fb6dccae348b954d9f625031b54711a9a33da525 3.10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Jul 7, 2022

bedevere-bot commented Jul 7, 2022

Copy link

Copy Markdown

GH-94670 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned erlend-aasland

Jul 7, 2022

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request

Jul 7, 2022


          [3.10] pythongh-94321: Document sqlite3.PrepareProtocol (pythonGH-94620…

d168606

…).

(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

bedevere-bot commented Jul 7, 2022

Copy link

Copy Markdown

GH-94671 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.10 label

Jul 7, 2022

erlend-aasland mentioned this pull request

Jul 7, 2022

Document sqlite3.PrepareProtocol #94321

Closed

miss-islington added a commit that referenced this pull request

Jul 7, 2022


          gh-94321: Document sqlite3.PrepareProtocol (GH-94620)

c72001e

(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

erlend-aasland added a commit that referenced this pull request

Jul 7, 2022


          [3.10] gh-94321: Document sqlite3.PrepareProtocol (GH-94620) (#94671)

797745e

(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>

Reviewers

CAM-Gerlach

CAM-Gerlach approved these changes

berkerpeksag

Awaiting requested review from berkerpeksag

Uh oh!

There was an error while loading. Please reload this page.

Assignees

erlend-aasland

Labels

docs

Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Document sqlite3.PrepareProtocol

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

erlend-aasland commented Jul 6, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland commented Jul 7, 2022

Uh oh!

erlend-aasland commented Jul 7, 2022

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

erlend-aasland commented Jul 7, 2022

Uh oh!

CAM-Gerlach left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Jul 7, 2022

Uh oh!

miss-islington commented Jul 7, 2022

Uh oh!

bedevere-bot commented Jul 7, 2022

Uh oh!

bedevere-bot commented Jul 7, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

erlend-aasland commented Jul 6, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.