GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-94644: fix test_curses ref leak by kumaraditya303 · Pull Request #94647 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Jul 7, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: test_curses reference leak in the Python main branch #94644

Automerge-Triggered-By: GH:tiran

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@kumaraditya303
fix curses ref leak
b1c924b
@bedevere-bot bedevere-bot added the awaiting review label Jul 7, 2022
@kumaraditya303 kumaraditya303 added the skip news label Jul 7, 2022
@kumaraditya303
kumaraditya303 requested a review from vstinner July 7, 2022 08:41
@tiran

tiran commented Jul 7, 2022

Copy link
Copy Markdown
Member

Thanks for the fix!

I have removed the "closes" line. The PR fixes the refleak but not the missing HAVE_NCURSEW problem.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran tiran added 3.11 only security fixes 3.12 only security fixes needs backport to 3.10 needs backport to 3.11 only security fixes labels Jul 7, 2022
tiran
tiran approved these changes Jul 7, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 7, 2022
@tiran tiran added the 🤖 automerge label Jul 7, 2022
@miss-islington
miss-islington merged commit 277f55c into python:main Jul 7, 2022
@miss-islington

miss-islington commented Jul 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 7, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2022
@kumaraditya303 @miss-islington
pythonGH-94644: fix test_curses ref leak (pythonGH-94647)
712db4f 
(cherry picked from commit 277f55c)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 7, 2022
@bedevere-bot

bedevere-bot commented Jul 7, 2022

Copy link
Copy Markdown

GH-94653 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2022
@kumaraditya303 @miss-islington
pythonGH-94644: fix test_curses ref leak (pythonGH-94647)
52992ad 
(cherry picked from commit 277f55c)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jul 7, 2022
@bedevere-bot

bedevere-bot commented Jul 7, 2022

Copy link
Copy Markdown

GH-94654 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 deleted the ref-leak branch July 7, 2022 11:12
miss-islington added a commit that referenced this pull request Jul 7, 2022
@miss-islington @kumaraditya303
GH-94644: fix test_curses ref leak (GH-94647)
c5819c1 
(cherry picked from commit 277f55c)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington added a commit that referenced this pull request Jul 7, 2022
@miss-islington @kumaraditya303
GH-94644: fix test_curses ref leak (GH-94647)
77a0153 
(cherry picked from commit 277f55c)

Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.11 only security fixes 3.12 only security fixes skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@kumaraditya303 @tiran @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.