GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-82504: deprecate the MultiLoopChildWatcher by graingert · Pull Request #94648 · python/cpython

Conversation

@graingert

@graingert graingert commented Jul 7, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x) #82504

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@graingert
deprecate the MultiLoopChildWatcher
161916c
@bedevere-bot bedevere-bot added the awaiting review label Jul 7, 2022
@graingert graingert changed the title bpo-82504: deprecate the MultiLoopChildWatcher gh-82504: deprecate the MultiLoopChildWatcher Jul 7, 2022
@blurb-it
📜🤖 Added by blurb_it.
5b2f920
@graingert graingert mentioned this pull request Jul 7, 2022
deprecate the asyncio child watchers system #94597
Closed
graingert added 2 commits July 7, 2022 10:12
@graingert
delete the skipped MultiLoopChildWatcher tests
88b01a4
@graingert
test that the MultiLoopChildWatcher is deprecated
9a2100f
@graingert
graingert marked this pull request as ready for review July 7, 2022 09:18
@graingert
graingert requested review from 1st1 and asvetlov as code owners July 7, 2022 09:18
@graingert
Merge branch 'main' into deprecate-multi-loop-watcher
a956000
kumaraditya303
kumaraditya303 reviewed Jul 18, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-07-07-09-04-49.gh-issue-82504.6xtYAz.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303
kumaraditya303 requested changes Jul 18, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to add What's New entry about this deprecation.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@graingert @kumaraditya303
Update Misc/NEWS.d/next/Library/2022-07-07-09-04-49.gh-issue-82504.6x…
ae826fa 
…tYAz.rst

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jul 18, 2022
graingert
graingert commented Jul 18, 2022
View reviewed changes
Comment thread Doc/library/asyncio-policy.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@graingert
Update Doc/library/asyncio-policy.rst
1ef16e9
graingert
graingert commented Jul 18, 2022
View reviewed changes
Comment thread Doc/library/asyncio-policy.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert added 2 commits July 18, 2022 16:21
@graingert
Update Doc/library/asyncio-policy.rst
dff64a5
@graingert
add what's new section for MultiLoopChildWatcher
4b379b4
kumaraditya303
kumaraditya303 reviewed Jul 18, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@graingert
move the MultiLoopChildWatcher deprecation to the empty 'Deprecated' …
a14a694 
…heading
graingert
graingert commented Jul 18, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.12.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
graingert added 3 commits July 18, 2022 17:11
@graingert
Update Doc/whatsnew/3.12.rst
821ccfc
@graingert
Merge branch 'main' into deprecate-multi-loop-watcher
69fe4d7
@graingert
split Deprecated by when the deprecations are schduled
2e6e996
@graingert
graingert force-pushed the deprecate-multi-loop-watcher branch from 84a0ca0 to 2e6e996 Compare July 18, 2022 16:20
@graingert
graingert requested a review from kumaraditya303 July 18, 2022 16:21
kumaraditya303
kumaraditya303 approved these changes Jul 18, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@graingert

graingert commented Jul 18, 2022

Copy link
Copy Markdown
Contributor Author

thanks for the review @kumaraditya303 !
kumaraditya303 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303

kumaraditya303 commented Jul 18, 2022

Copy link
Copy Markdown
Contributor

@gvanrossum Would you like to review this? This deprecates MultiLoopChildWatcher which has race conditions so it is not even tested on CI currently, skipped on CI as of #26542.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 requested a review from gvanrossum July 18, 2022 17:22
@gvanrossum

gvanrossum commented Jul 18, 2022

Copy link
Copy Markdown
Member

I'm sorry, I don't feel comfortable reviewing this. Any core dev CC'ed on the issue would be more qualified than me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
gvanrossum removed their request for review July 18, 2022 23:12
@graingert

graingert commented Jul 19, 2022

Copy link
Copy Markdown
Contributor Author

@kumaraditya303 can you request @njsmith on this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@graingert
Merge branch 'main' into deprecate-multi-loop-watcher
7f16eab
@kumaraditya303
kumaraditya303 requested review from njsmith and vstinner July 19, 2022 11:48
graingert added 2 commits July 22, 2022 20:31
@graingert
Merge branch 'main' into deprecate-multi-loop-watcher
d40b465
@graingert
Merge branch 'main' into deprecate-multi-loop-watcher
bc85892
@kumaraditya303

kumaraditya303 commented Oct 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Superseded by #98089
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood left review comments
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@njsmith njsmith Awaiting requested review from njsmith
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@graingert @kumaraditya303 @gvanrossum @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.