GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the test suite by pablogsal · Pull Request #26542 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Jun 4, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

https://bugs.python.org/issue38323

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@pablogsal
pablogsal requested review from 1st1 and asvetlov as code owners June 4, 2021 22:49
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 4, 2021
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jun 4, 2021
@pablogsal pablogsal mentioned this pull request Jun 4, 2021
bpo-38323, asyncio: Fix MultiLoopChildWatcher race condition #26536
Closed
@pablogsal
pablogsal requested a review from cjerdonek June 4, 2021 22:50
@pablogsal

pablogsal commented Jun 4, 2021

Copy link
Copy Markdown
Member Author

@cjerdonek could you take a look?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
1d87e07 
…est suite
@pablogsal
pablogsal force-pushed the bpo-38323 branch from decec3a to 1d87e07 Compare June 4, 2021 22:51
@pablogsal pablogsal added skip news needs backport to 3.9 labels Jun 4, 2021
cjerdonek
cjerdonek approved these changes Jun 4, 2021
View reviewed changes

@cjerdonek cjerdonek left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that looks fine.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 4, 2021
cjerdonek
cjerdonek reviewed Jun 4, 2021
View reviewed changes
Comment thread Lib/test/test_asyncio/test_subprocess.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
fixup! bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can han…
b577c0a 
…g the test suite
@pablogsal
pablogsal merged commit f171877 into python:main Jun 4, 2021
@pablogsal
pablogsal deleted the bpo-38323 branch June 4, 2021 23:33
@miss-islington

miss-islington commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 4, 2021
@miss-islington

miss-islington commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

Sorry @pablogsal, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker f171877ebe276749f31386baed5841ce37cbee2e 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned pablogsal Jun 4, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2021
@pablogsal @miss-islington
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
c48ccc3 
…est suite (pythonGH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <[email protected]>
@bedevere-bot

bedevere-bot commented Jun 4, 2021

Copy link
Copy Markdown

GH-26543 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Jun 4, 2021
@pablogsal pablogsal added needs backport to 3.10 and removed needs backport to 3.10 labels Jun 4, 2021
@miss-islington

miss-islington commented Jun 4, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Jun 4, 2021
@bedevere-bot

bedevere-bot commented Jun 4, 2021

Copy link
Copy Markdown

GH-26544 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 4, 2021
@pablogsal @miss-islington
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
ff6097c 
…est suite (pythonGH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <[email protected]>
miss-islington added a commit that referenced this pull request Jun 5, 2021
@miss-islington @pablogsal
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
b3c50b2 
…est suite (GH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <[email protected]>
pablogsal added a commit that referenced this pull request Jun 5, 2021
@miss-islington @pablogsal
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
0d441d2 
…est suite (GH-26542) (GH-26544)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <[email protected]>

Co-authored-by: Pablo Galindo <[email protected]>
@vstinner

vstinner commented Jun 7, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member 
 @unittest.skip("[bpo-38323](https://bugs.python.org/issue38323): MultiLoopChildWatcher has a race condition

FYI if a skip message contains "bpo-xxx", a buildbot fails when a PR is merged and the buildbot logs contain the skip message, the PR will be attached to bpo-xxx.

IMO the bot attaching PRs to bpo issues should only look into the PR title, not in PR comments.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Jun 7, 2021

Copy link
Copy Markdown
Member Author

FYI if a skip message contains "bpo-xxx", a buildbot fails when a PR is merged and the buildbot logs contain the skip message, the PR will be attached to bpo-xxx.

Well, hopefully soon we can merge some form of your PR and then remove that skip :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the needs backport to 3.8 label Jun 11, 2021
@miss-islington

miss-islington commented Jun 11, 2021

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 11, 2021

Copy link
Copy Markdown

GH-26670 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Jun 11, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2021
@pablogsal @miss-islington
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
5c750ad 
…est suite (pythonGH-26542)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <[email protected]>
pablogsal added a commit that referenced this pull request Jun 12, 2021
@miss-islington @pablogsal
bpo-38323: Skip SubprocessMultiLoopWatcherTest as they can hang the t…
af5fb67 
…est suite (GH-26542) (GH-26670)

(cherry picked from commit f171877)

Co-authored-by: Pablo Galindo <[email protected]>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
[3.10] Correct the order of regen-abidump #27228
Closed
@vstinner vstinner mentioned this pull request Apr 10, 2022
asyncio: MultiLoopWatcher has a race condition (test_asyncio: test_close_kill_running() hangs on AMD64 RHEL7 Refleaks 3.x) #82504
Closed
@kumaraditya303 kumaraditya303 mentioned this pull request Jul 18, 2022
gh-82504: deprecate the MultiLoopChildWatcher #94648
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
1 more reviewer
@cjerdonek cjerdonek cjerdonek approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@pablogsal pablogsal

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@pablogsal @miss-islington @bedevere-bot @vstinner @cjerdonek @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.