GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94215: Fix error handling for line-tracing events by brandtbucher · Pull Request #94681 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Jul 8, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Supersedes #94659. This properly restores frame state following an exception raised by a line-tracing event. It also adds some comments to clarify the (somewhat subtle) nearby code.

  • Issue: GC crash _PyObject_AssertFailed with pdb #94215

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 3 commits July 7, 2022 21:16
@brandtbucher
Re-enable crasher
dd820a9
@brandtbucher
Fix error handling for line-tracing events
bb7bb68
@brandtbucher
blurb add
d616b11
@brandtbucher brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes labels Jul 8, 2022
@brandtbucher
brandtbucher requested review from iritkatriel, pablogsal and tiran July 8, 2022 04:25
@brandtbucher
brandtbucher requested a review from markshannon as a code owner July 8, 2022 04:25
@brandtbucher brandtbucher self-assigned this Jul 8, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jul 8, 2022
@brandtbucher brandtbucher added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 8, 2022
@bedevere-bot

bedevere-bot commented Jul 8, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @brandtbucher for commit d616b11 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 8, 2022
@tiran tiran mentioned this pull request Jul 8, 2022
gh-94215: Fix reference count issue in exception_unwind #94659
Closed
tiran
tiran approved these changes Jul 8, 2022
View reviewed changes

@tiran tiran left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Build bots are happy, too.

Thanks for tracking down the root cause of the bug.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jul 8, 2022
iritkatriel
iritkatriel approved these changes Jul 8, 2022
View reviewed changes
@tiran

tiran commented Jul 8, 2022

Copy link
Copy Markdown
Member

Worker x86-64 macOS is stuck the initial preparation phase. Every other buildbot and CI task was successful.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tiran
tiran merged commit 23ee4a8 into python:main Jul 8, 2022
@miss-islington

miss-islington commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR, and @tiran for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 8, 2022
@miss-islington

miss-islington commented Jul 8, 2022

Copy link
Copy Markdown
Contributor

Sorry @brandtbucher and @tiran, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 23ee4a8067506e6c9c47748185653617413f7a60 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned tiran and unassigned brandtbucher Jul 8, 2022
tiran pushed a commit to tiran/cpython that referenced this pull request Jul 8, 2022
@brandtbucher @tiran
[3.11] pythongh-94215: Fix error handling for line-tracing events (py…
40bf64f 
…thonGH-94681)

* Re-enable crasher
* Fix error handling for line-tracing events
* blurb add
(cherry picked from commit 23ee4a8)

Co-authored-by: Brandt Bucher <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 8, 2022
@bedevere-bot

bedevere-bot commented Jul 8, 2022

Copy link
Copy Markdown

GH-94688 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran added a commit that referenced this pull request Jul 8, 2022
@tiran @brandtbucher
[3.11] gh-94215: Fix error handling for line-tracing events (GH-94681) (
36a3372 
GH-94688)

* Re-enable crasher
* Fix error handling for line-tracing events
* blurb add
(cherry picked from commit 23ee4a8)

Co-authored-by: Brandt Bucher <[email protected]>
@brandtbucher
brandtbucher deleted the line-tracing-exceptions branch July 21, 2022 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
+1 more reviewer
@tiran tiran tiran approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@tiran tiran

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@brandtbucher @bedevere-bot @tiran @miss-islington @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.