GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-93883: Fix some test involving traceback formatting by belm0 · Pull Request #94737 · python/cpython

Conversation

@belm0

@belm0 belm0 commented Jul 11, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

PR #93994 was merged without being rebased in a few weeks, and
some new test code using the old scheme passed through automatic merge.

  • Issue: 3.11 backtrace visual indicators are too verbose #93883

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@belm0
fix CI breakage
9acfc3c 
PR python#93994 was merged without being rebased in a few weeks, and
some new test code using the old scheme passed through automatic merge.
@belm0
belm0 requested a review from iritkatriel as a code owner July 11, 2022 08:42
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jul 11, 2022
@belm0

belm0 commented Jul 11, 2022

Copy link
Copy Markdown
Contributor Author

cc: @kumaraditya303

#93994 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood added the skip news label Jul 11, 2022
@belm0 belm0 mentioned this pull request Jul 11, 2022
gh-93883: elide traceback indicators when possible #93994
Merged
2 tasks done
@AlexWaygood

AlexWaygood commented Jul 11, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

You should change the title so it references the relevant GitHub issue (gh-93883)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@arhadthedev

arhadthedev commented Jul 11, 2022

Copy link
Copy Markdown
Member

cc @pablogsal as a merger of the original PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood requested a review from pablogsal July 11, 2022 08:45
@pablogsal pablogsal changed the title fix CI breakage gh-93883: Fix some test involving traceback formatting Jul 11, 2022
pablogsal
pablogsal approved these changes Jul 11, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Jul 11, 2022
@pablogsal
pablogsal merged commit 1fdc35e into python:main Jul 11, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Jul 11, 2022
@pablogsal

pablogsal commented Jul 11, 2022

Copy link
Copy Markdown
Member

@belm0 Can you prepare the backport of the original PR including this fix to 3.11?
belm0 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@belm0
belm0 deleted the ci-breakage branch July 11, 2022 10:42
belm0 added a commit to belm0/cpython that referenced this pull request Jul 11, 2022
@belm0
pythongh-93883: Fix some tests involving traceback formatting (python…
915d03e 
…#94737)

PR python#93994 was merged without being rebased in a few weeks, and
some new test code using the old scheme passed through automatic merge.

(cherry picked from commit 1fdc35e)
@belm0 belm0 mentioned this pull request Jul 11, 2022
[3.11] gh-93883: elide traceback indicators when possible (GH-93994) #94740
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@iritkatriel iritkatriel Awaiting requested review from iritkatriel

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@belm0 @AlexWaygood @arhadthedev @pablogsal @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.