GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-94751: Install, import and run the test C++ extension (MVP) (GH-94754) by miss-islington · Pull Request #94780 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 12, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is a quick-and-dirty way to run the C++ tests.
It can definitely be improved in the future, but it should fail when things go wrong.

  • Run test functions on import (yes, this can definitely be improved)
  • Fudge setuptools metadata (name & version) to make the extension installable
  • Install and import the extension in test_cppext
    (cherry picked from commit ec5db53)

Co-authored-by: Petr Viktorin [email protected]

  • Issue: test_cppext does not import/run the C++ extension #94751

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou @miss-islington
pythongh-94751: Install, import and run the test C++ extension (MVP) (p…
1ab009d 
…ythonGH-94754)

This is a quick-and-dirty way to run the C++ tests.
It can definitely be improved in the future, but it should fail when things go wrong.

- Run test functions on import (yes, this can definitely be improved)
- Fudge setuptools metadata (name & version) to make the extension installable
- Install and import the extension in test_cppext
(cherry picked from commit ec5db53)

Co-authored-by: Petr Viktorin <[email protected]>
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot mentioned this pull request Jul 12, 2022
gh-94751: Install, import and run the test C++ extension (MVP) #94754
Merged
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added skip news awaiting review labels Jul 12, 2022
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 12, 2022
@bedevere-bot

bedevere-bot commented Jul 12, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @encukou for commit 1ab009d 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jul 12, 2022
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
17 similar comments
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 12, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit ffbd6ae into python:3.11 Jul 13, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Jul 13, 2022
@miss-islington
miss-islington deleted the backport-ec5db53-3.11 branch July 13, 2022 09:09
@miss-islington

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
2 similar comments
@miss-islington

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a pending ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
10 similar comments
@miss-islington

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 21, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 24, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Jul 24, 2022

Copy link
Copy Markdown
Contributor Author

@encukou: Status check is done, and it's a failure ❌ .
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @bedevere-bot @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.