GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94759: Create LCOV report with branch coverage (GH-94793) by tiran · Pull Request #94793 · python/cpython

Conversation

@tiran

@tiran tiran commented Jul 12, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • fixed issue linker flags, LIBS is not passed to BLDSHARED
  • include version and git commit in output
  • include "Includes" directory, headers now have inline functions
  • Issue: Publish C-level coverage of the CPython test suite #94759

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tiran
pythongh-94759: Create LCOV report with branch coverage
f87ac08 
- fixed issue linker flags, LIBS is not passed to BLDSHARED
- include version and git commit in output
- include "Includes" directory, headers now have inline functions
@tiran tiran added build The build process and cross-build needs backport to 3.11 only security fixes labels Jul 12, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Jul 12, 2022
@tiran tiran added the skip news label Jul 12, 2022
@tiran
tiran requested a review from gpshead July 12, 2022 21:56
mdboom
mdboom approved these changes Jul 13, 2022
View reviewed changes

@mdboom mdboom left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried this and it works for me locally (Debian bookworm WSL)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tiran reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@tiran tiran changed the title gh-94759: Create LCOV report with branch coverage gh-94759: Create LCOV report with branch coverage (GH-94793) Jul 13, 2022
@tiran
tiran merged commit f5c02af into python:main Jul 13, 2022
@tiran
tiran deleted the lcov-branch branch July 13, 2022 14:35
@miss-islington

miss-islington commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

Thanks @tiran for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 13, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2022
@tiran @miss-islington
pythongh-94759: Create LCOV report with branch coverage (pythonGH-94793)
556f685 
(cherry picked from commit f5c02af)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 13, 2022
@bedevere-bot

bedevere-bot commented Jul 13, 2022

Copy link
Copy Markdown

GH-94804 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington added a commit that referenced this pull request Jul 13, 2022
@miss-islington @tiran
gh-94759: Create LCOV report with branch coverage (GH-94793)
f44a9dc 
(cherry picked from commit f5c02af)

Co-authored-by: Christian Heimes <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdboom mdboom mdboom approved these changes
@gpshead gpshead Awaiting requested review from gpshead

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build The build process and cross-build skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tiran @miss-islington @bedevere-bot @mdboom
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.